8000 Don't show the Largo update message for users that can't update by rnagle · Pull Request #855 · WPBuddy/largo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Don't show the Largo update message for users that can't update #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2015

Conversation

rnagle
Copy link
@rnagle rnagle commented Aug 19, 2015

For #854.

This pull request adds a check to the largo_update_admin_notice function to check if the current user can manage the network before printing the update message.

… doesn't show for users that can't do anything about it
@rnagle rnagle added priority: normal Must be completed before release of this version of plugin. status: needs review labels Aug 19, 2015
@aschweigert
Copy link

This will still display the notice for admins on standalone installs though right?

@rnagle
Copy link
Author
rnagle commented Aug 19, 2015

That's a good point. I just combed through and checked to make sure we're using the same capability (edit_theme_options) wherever we're checking to make sure a user is able to see and actually perform the update. The edit_theme_options capability is given to Administrator+ roles, so this should now work fine on multisite or single installs.

aschweigert added a commit that referenced this pull request Aug 19, 2015
Don't show the Largo update message for users that can't update
@aschweigert aschweigert merged commit 3431110 into master Aug 19, 2015
@aschweigert aschweigert deleted the 854-fix-update-message-capability branch August 19, 2015 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: normal Must be completed before release of this version of plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0