Allow floating social icons on two-column and other post templates #1102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Questions:
|
|
do we need any additional styling for this to make sure it gets positioned correctly? wasn't the reason we pulled it originally because it was appearing over the content in some cases? |
|
as far as i know there are no child themes we host, using 0.5.4, that alter the overall page width from the 1170px default |
|
i WOULD like to take a quick look at this on staging though, for all of the sites using the two column layout |
|
It was a worry. I've checked this against posts in themes with different single templates:
There haven't been any problems so far. The buttons are positioned outside the main page container div, so there haven't been conflicts. |
aschweigert
added a commit
that referenced
this pull request
Jan 27, 2016
…are-buttons Allow floating social icons on two-column and other post templates
benlk
added a commit
to INN/umbrella-largoproject
that referenced
this pull request
Jan 18, 2017
benlk
added a commit
to INN/umbrella-largoproject
that referenced
this pull request
Jan 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
largo_floating_social_button_width_json, to increase the minimum width of viewport needed for the floating social buttons when using a template other than Largo's single-column template1times the width of the floating social buttons to0.7times the width of the floating social buttonsWhy
For NPQ and VO-10, because we removed the sticky footer in 0.5.4.