8000 Search page improvements by benlk · Pull Request #1167 · WPBuddy/largo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Search page improvements #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 17, 2016
Merged

Search page improvements #1167

merged 7 commits into from
Mar 17, 2016

Conversation

benlk
Copy link
Collaborator
@benlk benlk commented Mar 8, 2016

Changes

  • Search results pages gain the archive class to get a lot of the styles we use in term archives.
  • Search results lose some custom per-article styles.
  • Default Largo search form in the main column of the search results page now has markup matching the header search form.
  • Search form in the main column of the search results page is now 100% width of column, with submit button at 10% width and the input at 90%. Also added: 0.5em padding-bottom, 1px dark grey border-bottom, 1em margin-bottom to put some space between the header and the results.
  • Excerpts in the content-search partial now default to 2 sentences instead of 5, matching the limits used elsewhere in Largo. (Not shown in the screenshots below.)

screen shot 2016-03-08 at 1 04 49 pm

screen shot 2016-03-08 at 12 53 11 pm

## Why

For #1162 and RNS-198.

@benlk benlk added this to the 0.5.5 - Story Elements milestone Mar 8, 2016
@benlk benlk assigned benlk and julia-smith and unassigned benlk Mar 8, 2016
@benlk
Copy link
Collaborator Author
benlk commented Mar 8, 2016

Julia, what feedback do you have?

@aschweigert
Copy link

the mobile view is a little odd with the search icon in the header and then the search box...we probably don't need both. I'd also consider slimming the results down even a bit more, probably no top tag, maybe no byline, a very short excerpt if possible. Smaller headline (probably), generally just make this a bit more compact and more search results-y

@benlk
Copy link
Collaborator Author
benlk commented Mar 8, 2016

I dunno, I think the longer excerpt is better for search results, in helping people find what they're looking for. Shorter excerpts feel clickbaity.

  • is removing the search icon in the header possible without a hideous conditional/css?
  • remove top tag
  • comment out byline (leaving placement there in case child themes want the byline)
  • shorter excerpt, to 1 sentence or the custom excerpt
  • remove the thumbnail

@benlk
Copy link
Collaborator Author
benlk commented Mar 8, 2016

screen shot 2016-03-08 at 4 36 39 pm

screen shot 2016-03-08 at 4 36 52 pm

@benlk benlk mentioned this pull request Mar 11, 2016
Merged
@benlk benlk assigned rnagle and unassigned julia-smith Mar 14, 2016
aschweigert added a commit that referenced this pull request Mar 17, 2016
@aschweigert
Merge pull request #1167 from INN/1162-search-style-improvements-RNS-198
6df98fb 
Search page improvements
@aschweigert aschweigert merged commit 6df98fb into develop Mar 17, 2016
@aschweigert aschweigert deleted the 1162-search-style-improvements-RNS-198 branch March 17, 2016 12:53
benlk added a commit that referenced this pull request Mar 17, 2016
@benlk
Merge branch 'master' into develop, rebuild translation files and CSS
4ce191f 
- This uses the copy of lang/es_ES.po from master instead of merging
- Rebuilt translation files with `grunt pot shell:msmerge`
- Rebuilt css with `grunt less cssmin`
- Resolves conflict in `searchform.php` from difference between \#1168 and \#1167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rnagle rnagle

Labels
type: improvement
Projects
None yet
Milestone
0.5.5 - Story Elements
Development

Successfully merging this pull request may close these issues.
4 participants
@benlk @aschweigert @rnagle @julia-smith
0