8000 Update ADWINChangeDetector.java by hmgomes · Pull Request #251 · Waikato/moa · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update ADWINChangeDetector.java #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2022
Merged

Update ADWINChangeDetector.java #251

merged 1 commit into from
Apr 6, 2022

Conversation

hmgomes
Copy link
Member
@hmgomes hmgomes commented Apr 6, 2022

this.isChangeDetected is never reset after a change is detected

if(adwin.setInput(inputValue)) {
            if (this.adwin.getEstimation() > ErrEstim) {
                this.isChangeDetected = true;
            }
        }

Therefore, after a drift is detected, code using this class always obtain a "change detected" signal

@hmgomes
Update ADWINChangeDetector.java
8d34a52 
this.isChangeDetected is never reset after a change is detected

'''
if(adwin.setInput(inputValue)) {
            if (this.adwin.getEstimation() > ErrEstim) {
                this.isChangeDetected = true;
            }
        }
'''

Therefore, after a drift is detected, code using this class always obtain a "change detected" signal
@abifet abifet merged commit a978d49 into Waikato:master Apr 6, 2022
@nuwangunasekara nuwangunasekara mentioned this pull request Aug 27, 2022
Closed
@nuwangunasekara nuwangunasekara mentioned this pull request Sep 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hmgomes @abifet
0