-
-
Notifications
You must be signed in to change notification settings - Fork 30
feat(robo/cli) static cloudflare support #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Pkmmte
merged 7 commits into
Wave-Play:main
from
waruhachi:feat(robo/cli)-static-cloudflare-support
Feb 23, 2025
Merged
feat(robo/cli) static cloudflare support #417
Pkmmte
merged 7 commits into
Wave-Play:main
from
waruhachi:feat(robo/cli)-static-cloudflare-support
Feb 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create-discord-activity
@robojs/ai
@robojs/ai-voice
create-robo
@robojs/server
@robojs/better-stack
@roboplay/plugin-confessions
@robojs/dev
@roboplay/plugin-gpt
@robojs/maintenance
@robojs/moderation
@roboplay/plugin-poll
@robojs/sync
robo.js
@roboplay/sage
@robojs/analytics
@robojs/cron
@robojs/patch
@robojs/trpc
commit: |
Pkmmte
requested changes
Feb 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice overall, but there's a few areas that need work:
- Error handling for missing
.env
- Excessive logging for those that don't opt-in
- Avoid
overwrite: true
inEnv.load
for this purpose
Once the above has been resolved, I'll do another deeper review pass. 👍
fafa791
to
257294a
Compare
…with proper handling of DNS records
…also Implement basic error handling for Cloudflare tunnel connections
…ging in Cloudflare tunnel
257294a
to
f014cdd
Compare
Pkmmte
approved these changes
Feb 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
haha, second time is the charm 😅