Password reset link test condition more strict and move all WebWolf links to /WebWolf #1645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might as well look at migrating WebWolf to the bootstrap 5 |
|
Still some manual testing to do to see if all things are working ok |
…ic support for oauth (more work needed)
|
@zubcevic I'll take a look and be back soon. |
aolle
previously requested changes
Nov 11, 2023
10000
src/main/java/org/owasp/webgoat/container/WebSecurityConfig.java
Outdated
Show resolved
Hide resolved
aolle
approved these changes
Nov 13, 2023
| Object handler, | ||
| ModelAndView modelAndView) | ||
| throws Exception { | ||
| // Do nothing |
There was a problem hiding this comment.
I believe this comment may have been overlooked and could be removed.
nbaars
pushed a commit
that referenced
this pull request
Mar 19, 2024
…inks to /WebWolf (#1645) * better check on host and port for password reset and make context roots more flexible * spotless applied * removed hardcoded /WebGoat from js * removed hardcoded /WebGoat from js * fix spotless * fix scoreboard * upgrade WebWolf bootstrap version and icons and templates - part 1 * fixed more bootstrap 5 style issues and context path issues * organized WebSecurityConfig based on latest conventions and added basic support for oauth (more work needed) * spotless applied * added mock bean * requires updates to properties - commented for now * requires updates to properties - commented for now * oauth secrets through env values * user creation after oauth login * integration test against non default context paths * adjusted StartupMessage * add global model element username * conditionally show login oauth links * fixed WebWolf login --------- Co-authored-by: René Zubcevic <rene@Mac-mini-van-Rene.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The password reset link test condition was not strict enough.
Also I added context-path in the properties and corrected hardcoded context path to be able to change the context roots.
WebWolf is now using /WebWolf all in one context root as is the same for /WebGoat.
I still have to check of all the links in the static pages are still ok.