fix: Hint labels showing default text regardless of localization #1965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Regardless of the presence of localized label for the hint button, when toggling the button, default hardcoded text would be displayed. Modification: In the `toggleLabel` function in `HintView.js`, `polyglot` is used to translate the hint labels rather than using hardcoded texts. Result: The hint button correctly shows the localized labels for the hint button and falling back to the English version if it is absent. Fixes WebGoat#1944
|
@roksui merged, thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Regardless of the presence of localized label for the hint button, when toggling the button, default hardcoded text would be displayed.
Modification:
In the
toggleLabelfunction inHintView.js,polyglotis used to translate the hint labels rather than using hardcoded texts.Result:
The hint button correctly shows the localized labels for the hint button and falling back to the English version if it is absent.
Fixes #1944