8000
Prevented foobar crash when exiting during AllMusic fetching by TT-ReBORN · Pull Request #8 · Wil-B/Biography · GitHub
More Web Proxy on the site http://driver.im/
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@TT-ReBORN just to confirm, the current code handles only a single request at a time. Is that intended?
Just asking, as far as I see the previous one allowed to send multiple request when changing selection and processing them on the background via promises (correct me if I'm wrong, but at least that seems the flow).
Your PR is not only a fix but a change on behavior, since every send call aborts the previous request instead of pushing them into a stack and aborting the entire stack on the unload callback (which was my proposed solution).
Yes, it should process single requests and start fresh again.
Imo this is the cleanest way and performance wise ( client <-> server side ), we do not need to have multiple request
processed because we only fetch text ( which is instant ) and no images like last.fm does.
I do not see any side effects, I have tested it with Majestyk and we didn't encounter any issues.
regorxxx
added a commit
to regorxxx/Biography
that referenced
this pull request
Oct 8, 2024
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title says, more info here:
https://hydrogenaud.io/index.php/topic,121047.msg1044579.html#msg1044579
@regorxxx, you can close your open PR as it is with this PR deprecated: #7