10000 Fix Debug.WriteLine exception issue by duduita · Pull Request #421 · WildernessLabs/Meadow.CLI · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Debug.WriteLine exception issue #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

duduita
Copy link
Contributor
@duduita duduita commented Dec 28, 2023

Skipping the System.Configuration trimming fixes the Debug.WriteLine() exception. It increases the .dll size by ~60kB, which seems like an acceptable workaround side effect.

@duduita duduita requested review from alexischr and ctacke December 28, 2023 13:49
@ctacke
Copy link
Contributor
ctacke commented Dec 28, 2023

You can achieve this without code change by adding the assembly to meadow_link.xml:
https://github.com/WildernessLabs/Meadow.CLI/blob/develop/Meadow.CLI.Core/lib/meadow_link.xml

@duduita duduita force-pushed the fix-debug-writeline-exception branch from 9c86092 to fc6d013 Compare December 28, 2023 18:38
@duduita
Copy link
Contributor Author
duduita commented Dec 28, 2023

Thank you for the hint @ctacke. Done!

@alexischr
Copy link
Contributor

CLI errors seem unrelated - but is CLI CI broken?

@alexischr alexischr merged commit 2cabeca into develop Dec 29, 2023
@alexischr alexischr deleted the fix-debug-writeline-exception branch December 29, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0