Update roe.lua #2057
Merged
Update roe.lua #2057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 16, 2021 20:59
See discord message
|
The blacklist by default has no entries, so this does nothing almost. Ideally we would ignore blacklist all together and not allow it to set\save those ranges since they are limited time anyway imo,with a warning it could not set certain ROEs. Also you forgot to version bump. |
|
That's odd. My version does have it in the settings file. Not sure how it got there, I wouldn't have put it there myself. |
|
This commit is better -- it just prevents the illicit RoE's from being set. Don't need to worry about the blacklist. (I know you don't like single line if statements I'm just keeping with the convention of the addon. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discord message