8000 Migrate "old" conditions by Cyperghost · Pull Request #6330 · WoltLab/WCF · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Migrate "old" conditions #6330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Jul 14, 2025
Merged

Migrate "old" conditions #6330

merged 31 commits into from
Jul 14, 2025

Conversation

Cyperghost
Copy link
Contributor
@Cyperghost Cyperghost commented Jun 10, 2025 •
edited
Loading

Ref #6304
See #6310

TODO

  • Change branch to 6.3-condition

@Cyperghost Cyperghost requested a review from dtdesign June 10, 2025 10:09
@Cyperghost Cyperghost force-pushed the 6.3-condition-migrate branch from 9565c65 to f2e7e53 Compare June 18, 2025 09:57
dtdesign
dtdesign requested changes Jun 25, 2025
View reviewed changes
8000
Cyperghost and others added 14 commits June 29, 2025 18:06
@Cyperghost
Rename 'needMigration' to 'isLegacy'
d341eeb
@Cyperghost @dtdesign
Apply suggestions from code review
b580699 
Co-authored-by: Alexander Ebert <ebert@woltlab.com>
@Cyperghost
Merge remote-tracking branch 'origin/6.3-condition-migrate' into 6.3-…
470ccc9 
…condition-migrate
@Cyperghost
Refactor ConditionMigration
494f1b2
@Cyperghost
Refactor migration condition checks for consistency
5daa363
@Cyperghost
Refactor condition data migration logic to improve null handling
c897624
@Cyperghost
Migrate user condition types to use named parameters for improved rea…
6aeb7e3 
…dability
@Cyperghost
Add legacy notice for automatic user group assignments and implement …
c341d5b 
…migration worker
@Cyperghost
Rename UserGroupAssignmentMigrateCondition to MigrateLegacyCondition
7716d1d
@Cyperghost
Fix typo in $field
7458aa7
@Cyperghost
Add error handling for JSON decoding in condition migration
a72f4ee
@Cyperghost
Fix incorrect usage of unset function in ConditionHandler
0361a8a
@Cyperghost
Use DateTimeImmutable instead of \DateTime
ed94ef7
@Cyperghost
Expand the PHPDoc for methods in IMigrateConditionType
80ef76e
@Cyperghost Cyperghost requested a review from dtdesign June 30, 2025 15:24
dtdesign
10000 dtdesign requested changes Jul 4, 2025
View reviewed changes
Copy link
Member
@dtdesign dtdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add an ACP status box of type warning to notify about outstanding migrations.

@Cyperghost Cyperghost requested a review from dtdesign July 7, 2025 08:48
dtdesign and others added 8 commits July 10, 2025 23:40
@dtdesign
\strtolower() is not binary-safe
770801e
@dtdesign
Fix the handling of condition types
ed0f57b
@dtdesign
Mark the abstract user conditions as non-abstract
f99335a 
If we're going to instantiate them via anonymous classes, we can just drop the `abstract` because their entire implementation is non-abstract anyway.
@dtdesign
Register the conditions sequentually
4acb7a3 
There is very little gain in offering `addConditions()` plus it requires us to validate an arbitrary array in contrast to relying on `addCondition()` with its type hin.
@dtdesign
Fix the direction of the comparison
388be41
@dtdesign
Simplify the condition names
d1c8eb1 
Avoiding the repetition makes it easier to find conditions.
@Cyperghost
Rename the class to the correct name
3c7a46c 
Add phpstan docs
@Cyperghost
Adding language variable
c54f1b5 
The content of `wcf.condition.add` has been swapped between German and English.
@Cyperghost Cyperghost marked this pull request as ready for review July 14, 2025 08:00
@Cyperghost Cyperghost changed the title (PoC) Migrate "old" conditions Migrate "old" conditions Jul 14, 2025
@Cyperghost Cyperghost merged commit 18b3879 into 6.3-condition-conditions Jul 14, 2025
9 of 10 checks passed
@Cyperghost Cyperghost deleted the 6.3-condition-migrate branch July 14, 2025 08:00
< 6281 input type="hidden" name="variables[subjectId]" value="PR_kwDOAB9BDc6Z08g2">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtdesign dtdesign dtdesign requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cyperghost @dtdesign
0