wp-env: remove mappings field #774
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #764, the local
dev-env/themesdirectory is now mapped to thewp-content/themesdirectory to make it easier to create or check changes to themes.This may be convenient, but in the initial setup, there are no themes, which causes the following problems:
55c6c3481a08a9153af05bf7f7e6058e.mp4
The
mappingsfield should be excluded from the default settings. Contributors who really need the mapping can do so by creating a.wp-env.override.jsonfile like this:{ "mappings": { "wp-content/themes": "./dev-env/themes" } }