8000 [WOR-3837] Logged-in new agent creation screen by jacekzimonski · Pull Request #20 · WorkflowAI/WorkflowAI · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[WOR-3837] Logged-in new agent creation screen #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 1, 2025
Merged

[WOR-3837] Logged-in new agent creation screen #20

merged 5 commits into from
Apr 1, 2025

Conversation

jacekzimonski
Copy link
Contributor
@jacekzimonski jacekzimonski commented Mar 28, 2025 •
edited
Loading

@jacekzimonski jacekzimonski requested a review from guillaq March 28, 2025 15:40
@jacekzimonski jacekzimonski self-assigned this Mar 28, 2025
@vercel Vercel
Copy link
vercel bot commented Mar 28, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
workflowai.com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2025 4:55pm

@jacekzimonski
Copy link
Contributor Author

@anyacherniss
Ready for QA!

@anyacherniss
Copy link
Contributor
anyacherniss commented Mar 28, 2025 •
edited
Loading

QA is done

  • Is it possible to keep the full screen chat when the user enters a message that doesn't immediately generate a schema?
    CleanShot 2025-03-28 at 14 23 27@2x

  • When I press "enter" to submit the feature description, the text field in the chat has an extra line added

CleanShot.2025-03-28.at.14.25.24.mp4
  • Not seeing the expected response from the chat agent when creating a new schema. Not sure if the message is hardcoded in this PR or something? Expecting the same template message that's shown in the app right now
CleanShot.2025-03-28.at.14.27.01.mp4

Current message shown in the app

CleanShot 2025-03-28 at 14 29 58@2x

  • When selecting a prompt from the customer URL section, no message is shown as sent from the user. Not sure if there is something missing on the backend?

(see second half of screen recording above)

  • Would be great if we could support new lines/expanding the text field a bit (like the current UX). Not sure if it would look weird with the new UI though 😬 , but worth trying if it doesn't take too long?
CleanShot.2025-03-28.at.14.33.45.mp4

@jacekzimonski
- [x] Is it possible to keep the full screen chat when the user enter…
c67dfaf 
…s a message that doesn't immediately generate a schema?

- [x] When I press "enter" to submit the feature description, the text field in the chat has an extra line added
- [x] Not seeing the expected response from the chat agent when creating a new schema. Not sure if the message is hardcoded in this PR or something? Expecting the same template message that's shown in the app right now. Current message shown in the app.
- [x] When selecting a prompt from the customer URL section, no message is shown as sent from the user. Not sure if there is something missing on the backend?
- [x] Would be great if we could support new lines/expanding the text field a bit (like the current UX). Not sure if it would look weird with the new UI though 😬 , but worth trying if it doesn't take too long?
@jacekzimonski
Copy link
Contributor Author
jacekzimonski commented Mar 31, 2025 •
edited
Loading

@anyacherniss

Reported issues were fixed:

  • Is it possible to keep the full screen chat when the user enters a message that doesn't immediately generate a schema?
  • When I press "enter" to submit the feature description, the text field in the chat has an extra line added
  • Not seeing the expected response from the chat agent when creating a new schema. Not sure if the message is hardcoded in this PR or something? Expecting the same template message that's shown in the app right now. Current message shown in the app.
  • When selecting a prompt from the customer URL section, no message is shown as sent from the user. Not sure if there is something missing on the backend?
  • Would be great if we could support new lines/expanding the text field a bit (like the current UX). Not sure if it would look weird with the new UI though 😬 , but worth trying if it doesn't take too long?

More explanation for some issues that were reported and how they were solved:

Not seeing the expected response from the chat agent when creating a new schema. Not sure if the message is hardcoded in this PR or something? Expecting the same template message that's shown in the app right now. Current message shown in the app.

@ anyacherniss
Because we have the schema from a different response, that does not provide us with a message back it’s hardcoded in the case of selecting a feature.

  • But did adjust the hardcoded message to mirror the one we would get from backend, so now it should be ok.

When selecting a prompt from the customer URL section, no message is shown as sent from the user. Not sure if there is something missing on the backend?

In the Feature the message should be feature.specifications but it’s missing for some features. So it looks like it’s backend not sending us the specification. But to still show a message I did a change in that now:

  • When specification is empty I’m treating the feature.description as the message
  • @ anyacherniss Please confirm that’s the preferred solution, if not we need to add them to the backend response.

@anyacherniss
Ready for re-QA!

@anyacherniss
Copy link
Contributor

@ anyacherniss Please confirm that’s the preferred solution, if not we need to add them to the backend response.

This works for me. Thank you @jacekzimonski!

QA is done

  • When the message is multiple lines, can the button stay at the bottom? (see current button placement).

CleanShot 2025-03-31 at 09 37 39@2x
CleanShot 2025-03-31 at 09 37 33@2x

  • Subtle, but when I enter a multiline prompt, the textbox and sidebar text become a bit blurred. Really hard to see in the video, but it's more obvious in reality.
CleanShot.2025-03-31.at.10.14.34.mp4

@jacekzimonski
Fixed reported issues:
b4f18b9 
- [x] When the message is multiple lines, can the button stay at the bottom? (see current button placement).
- [x] Subtle, but when I enter a multiline prompt, the textbox and sidebar text become a bit blurred. Really hard to see in the video, but it's more obvious in reality.
@jacekzimonski
Copy link
Contributor Author
jacekzimonski commented Apr 1, 2025 •
edited
Loading

@anyacherniss

Fixed reported issues:

  • When the message is multiple lines, can the button stay at the bottom? (see current button placement).
  • Subtle, but when I enter a multiline prompt, the textbox and sidebar text become a bit blurred. Really hard to see in the video, but it's more obvious in reality.

@anyacherniss
Ready for re-QA!

@anyacherniss
Copy link
Contributor

This passes QA 👍

@jacekzimonski jacekzimonski merged commit 76827b5 into main Apr 1, 2025
6 checks passed
@jacekzimonski jacekzimonski deleted the jacek/WOR-3837-Logged-in-new-agent-creation-screen branch April 1, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaq guillaq guillaq approved these changes

@anyacherniss anyacherniss Awaiting requested review from anyacherniss

Assignees

@jacekzimonski jacekzimonski

@anyacherniss anyacherniss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacekzimonski @anyacherniss @guillaq
0