8000 [WOR-3867] Try input in playground causes empty field to be uneditable by guillaq · Pull Request #5 · WorkflowAI/WorkflowAI · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[WOR-3867] Try input in playground causes empty field to be uneditable #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 28, 2025
Merged

[WOR-3867] Try input in playground causes empty field to be uneditable #5

merged 4 commits into from
Mar 28, 2025

Conversation

guillaq
Copy link
Contributor
@guillaq guillaq commented Mar 27, 2025

@linear Linear
Copy link
linear bot commented Mar 27, 2025
WOR-3867 "Try input in playground" causes empty field to be uneditable

Example run that this can be reproduced with: https://workflowai.com/workflowai/agents/improve-prompt/15/runs?page=0&taskRunId=019565a7-0da9-7256-149f-c6df60905a67

Expected behavior: if a field is empty (null, or empty value), the field should be empty (but still editabled) in the playground

Actual behavior: there is no editable text field shown for the corresponding name

Repro steps:

  1. Find a run with an input where at least one of the values is empty (ex https://workflowai.com/workflowai/agents/improve-prompt/15/runs?page=0&taskRunId=019565a7-0da9-7256-149f-c6df60905a67)
  2. Tap "Try input in playground"

CleanShot 2025-03-05 at 10.36.37.mp4

@vercel Vercel
Copy link
vercel bot commented Mar 27, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
workflowai.com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2025 4:57pm

@guillaq guillaq force-pushed the guillaume/import-client branch 3 times, most recently from f4f24ed to d4cc05d Compare March 27, 2025 01:54
@guillaq guillaq force-pushed the feature/WOR-3867-Try-input-in-playground-causes-empty-field-to-be-uneditable branch from ea5df88 to 569d965 Compare March 27, 2025 01:55
@guillaq guillaq force-pushed the guillaume/import-client branch from d4cc05d to 22e9309 Compare March 27, 2025 01:59
@guillaq guillaq force-pushed the feature/WOR-3867-Try-input-in-playground-causes-empty-field-to-be-uneditable branch from 569d965 to 3eb1681 Compare March 27, 2025 02:00
Base automatically changed from guillaume/import-client to main Marc 8000 h 27, 2025 02:06
@jacekzimonski jacekzimonski self-requested a review March 27, 2025 09:18
@jacekzimonski jacekzimonski changed the title Try input in playground causes empty field to be uneditable [WOR-3867] Try input in playground causes empty field to be uneditable Mar 27, 2025
@anyacherniss
Copy link
Contributor

https://github.com/WorkflowAI/workflowai.com/pull/1527#issuecomment-2755642066

@guillaq guillaq force-pushed the main branch 4 times, most recently from b6c3adc to b168f6f Compare March 28, 2025 01:52
@jacekzimonski
Copy link
Contributor

@anyacherniss

Did investigation about reported case, and it's different then what we had:

  • In this case the Schema 10 is invalid
  • It lacks the type for those two fields
  • Becasue there is not type + no value (that could be checked and verified to be a string), we don't know what should be the value
  • That's why we are showing undefined
  • But this thing should never happen when creating schema
  • And we are actually correctly now marking those types in the Schema Modal Editor as string
  • Attached the recording of what happens when I open the editor, do no changes and still am able to save the new schema

@anyacherniss
So in this case we have like a old schema that was created probably becasue of a earlier bug:
Screen Recording 2025-03-28 at 5 49 49 PM

@anyacherniss
Copy link
Contributor

This passes QA 👍

CleanShot.2025-03-28.at.13.19.44.mp4

@jacekzimonski jacekzimonski merged commit ddde25e into main Mar 28, 2025
6 checks passed
@jacekzimonski jacekzimonski deleted the feature/WOR-3867-Try-input-in-playground-causes-empty-field-to-be-uneditable branch March 28, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacekzimonski jacekzimonski jacekzimonski approved these changes

@anyacherniss anyacherniss Awaiting requested review from anyacherniss

Assignees

@jacekzimonski jacekzimonski

@anyacherniss anyacherniss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guillaq @anyacherniss @jacekzimonski
0