8000 Fix LDAP connection leak during policy update. #6 by pavelhoral · Pull Request #7 · WrenSecurity/wrenam · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix LDAP connection leak during policy update. #6 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2017
Merged

Fix LDAP connection leak during policy update. #6 #7

merged 1 commit into from
Nov 27, 2017

Conversation

pavelhoral
Copy link
Member

No description provided.

@pavelhoral
Copy link
Member Author

Seems this is not the only leak... so maybe wait for confirmation before accepting / merging.

@pavelhoral
Copy link
Member Author

False alarm... the fix works.

siepkes
siepkes approved these changes Nov 27, 2017
View reviewed changes
Copy link
Member
@siepkes siepkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

siepkes
siepkes requested changes Nov 27, 2017
View reviewed changes
Copy link
Member
@siepkes siepkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost forgot; You need to update the license header of the file you made changes to.

@pavelhoral
Copy link
Member Author

Commit updated.

siepkes
siepkes approved these changes Nov 27, 2017
View reviewed changes
Copy link
Member
@siepkes siepkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

9030
@siepkes siepkes merged commit fa0e6f7 into WrenSecurity:develop Nov 27, 2017
@siepkes siepkes mentioned this pull request Nov 27, 2017
Closed
MarkkuPekkarinen added a commit to MarkkuPekkarinen/wrenam that referenced this pull request Jan 1, 2018
@MarkkuPekkarinen
Merge pull request #1 from WrenSecurity/develop
2873450 
Fix LDAP connection leak during policy update. (WrenSecurity#7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siepkes siepkes siepkes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelhoral @siepkes
0