8000 Fix Wren:DS directory detection by pavelhoral · Pull Request #184 · WrenSecurity/wrenam · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Wren:DS directory detection #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2025
Merged

Fix Wren:DS directory detection #184

merged 1 commit into from
Apr 1, 2025

Conversation

pavelhoral
Copy link
Member

Fix detection that prevents import-svc-cfg invocation.

$ .\ssoadm import-svc-cfg -e secret -u amadmin -f password.txt -X config.xml

Unable to import service configuration because we are unable to recognize the data store type. We support Sun Directory Server and Embedded OpenDJ as service configuration data store.

@pavelhoral pavelhoral force-pushed the fix-wrends-detection branch from 2c08128 to 5ecfc30 Compare April 1, 2025 09:36
karelmaxa
karelmaxa requested changes Apr 1, 2025
View reviewed changes
openam-core/src/main/java/com/sun/identity/sm/DirectoryServerVendor.java Outdated
@@ -106,7 +109,10 @@ public Vendor query(Connection conn) throws LdapException, SearchResultReference
Vendor vendor = unknownVendor;

if (result != null) {
if (result.startsWith(VENDOR_OPENDJ)) {
if (result.startsWith(VENDOR_WRENDS)) {
String version = result.substring(VENDOR_WRENDS.length());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please replace tabs with spaces?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed🤦

@pavelhoral pavelhoral force-pushed the fix-wrends-detection branch from 5ecfc30 to 21930d1 Compare April 1, 2025 10:59
@pavelhoral pavelhoral force-pushed the fix-wrends-detection branch from 21930d1 to c188fe7 Compare April 1, 2025 11:23
karelmaxa
karelmaxa approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member
@karelmaxa karelmaxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@karelmaxa karelmaxa merged commit 0abef93 into WrenSecurity:main Apr 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karelmaxa karelmaxa karelmaxa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelhoral @karelmaxa
0