8000 feat: Pass sanitizer as part of conan_profile by mathbunnyru · Pull Request #2189 · XRPLF/clio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Pass sanitizer as part of conan_profile #2189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

mathbunnyru
Copy link
Collaborator
@mathbunnyru mathbunnyru commented Jun 5, 2025

I noticed we don't need sanitizer value anymore, so removed it.

@mathbunnyru mathbunnyru marked this pull request as draft June 5, 2025 18:14
@mathbunnyru mathbunnyru changed the title feat: Add ubsan build to nightly release feat: Pass sanitizer as part of conan_profile Jun 5, 2025
@mathbunnyru mathbunnyru marked this pull request as ready for review June 6, 2025 19:09
Copy link
codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.27%. Comparing base (2d172f4) to head (a263016).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2189      +/-   ##
===========================================
+ Coverage    73.26%   73.27%   +0.01%     
===========================================
  Files          368      368              
  Lines        14977    14977              
  Branches      7595     7595              
===========================================
+ Hits         10973    10975       +2     
- Misses        1898     1899       +1     
+ Partials      2106     2103       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mathbunnyru mathbunnyru requested a review from godexsoft June 10, 2025 13:58
Copy link
Collaborator
@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@mathbunnyru mathbunnyru merged commit 6e0d7a0 into XRPLF:develop Jun 10, 2025
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0