8000 fix: Only set compile flag for grpc by mathbunnyru · Pull Request #2204 · XRPLF/clio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Only set compile flag for grpc #2204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

mathbunnyru
Copy link
Collaborator
@mathbunnyru mathbunnyru commented Jun 10, 2025

I built all conan packages locally and this flag is only required for grpc, so let's only set it for grpc.
This is better - it's explicit, and we'll know that if we update grpc recipe, we can remove this.

I also uploaded all rebuilt packages to the artifactory.

@mathbunnyru mathbunnyru requested a review from godexsoft June 10, 2025 13:58
Copy link
Collaborator
@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. How can we make sure that we won't forget to update/remove this when we update the version? Do we have an issue for this?

@mathbunnyru mathbunnyru merged commit d3c98ab into XRPLF:develop Jun 10, 2025
6 checks passed
@mathbunnyru
Copy link
Collaborator Author

Good idea. How can we make sure that we won't forget to update/remove this when we update the version? Do we have an issue for this?

Decided to not create an issue for this change, even if we forget to remove from docs for some time - there will be no harm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0