8000 feat: Support start and finish sequence in ETLng by godexsoft · Pull Request #2226 · XRPLF/clio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Support start and finish sequence in ETLng #2226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

godexsoft
Copy link
Collaborator

This PR adds support for start and finish sequence specified through the config (for parity).

Copy link
codecov bot commented Jun 13, 2025

Codecov Report

Attention: Patch coverage is 38.09524% with 13 lines in your changes missing coverage. Please review.

Project coverage is 73.20%. Comparing base (59bb9a1) to head (30e16db).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/etlng/ETLService.cpp 53.33% 3 Missing and 4 partials ⚠️
src/etlng/impl/TaskManagerProvider.hpp 0.00% 5 Missing ⚠️
src/etl/ETLService.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2226      +/-   ##
===========================================
- Coverage    73.22%   73.20%   -0.03%     
===========================================
  Files          370      370              
  Lines        15082    15094      +12     
  Branches      7656     7662       +6     
===========================================
+ Hits         11044    11049       +5     
- Misses        1915     1920       +5     
- Partials      2123     2125       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@godexsoft godexsoft marked this pull request as ready for review June 13, 2025 15:46
Copy link
Collaborator
@kuznetsss kuznetsss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mathbunnyru mathbunnyru merged commit 3d3db68 into XRPLF:develop Jun 13, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0