8000 fix: Return domainMalformed when domain is malformed by mathbunnyru · Pull Request #2228 · XRPLF/clio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Return domainMalformed when domain is malformed #2228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

fix: Return domainMalformed when domain is malformed #2228

merged 1 commit into from
Jun 16, 2025

Conversation

mathbunnyru
Copy link
Collaborator

@mathbunnyru mathbunnyru requested a review from godexsoft June 16, 2025 14:14
@codecov Codecov
Copy link
codecov bot commented Jun 16, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.17%. Comparing base (95698ee) to head (de15353).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/rpc/handlers/BookOffers.hpp 25.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2228      +/-   ##
===========================================
- Coverage    73.19%   73.17%   -0.03%     
===========================================
  Files          370      370              
  Lines        15094    15097       +3     
  Branches      7662     7665       +3     
===========================================
- Hits         11048    11047       -1     
  Misses        1920     1920              
- Partials      2126     2130       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

godexsoft
godexsoft approved these changes Jun 16, 2025
View reviewed changes
Copy link
Collaborator
@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct 👍

@mathbunnyru mathbunnyru merged commit f58c85d into XRPLF:develop Jun 16, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godexsoft godexsoft godexsoft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid domain in book_offers returns invalidParams instead of domainMalformed(Version: [20250612161611-develop-0273ba0d])
2 participants
@mathbunnyru @godexsoft
0