fix: Add sending queue to ng web server #2273
Open
+402
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2273 +/- ##
========================================
Coverage 73.22% 73.22%
========================================
Files 372 373 +1
Lines 15277 15304 +27
Branches 7727 7731 +4
========================================
+ Hits 11186 11206 +20
- Misses 1935 1937 +2
- Partials 2156 2161 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
godexsoft
requested changes
Jul 1, 2025
mathbunnyru
reviewed
Jul 2, 2025
mathbunnyru
reviewed
Jul 3, 2025
| @@ -50,24 +51,31 @@ SubscriptionContext::SubscriptionContext( | |||
| { | |||
| } | |||
|
|
|||
| SubscriptionContext::~SubscriptionContext() | |||
| { | |||
| ASSERT(disconnected_, "SubscriptionContext must be disconnected before destroying"); | |||
There was a problem hiding this comment.
That's UB if the exception is thrown, but I think we should be fine.
There was a problem hiding this comment.
We throw exceptions from ASSERT() only in tests. I don't think there is a better way to check this, but I will think how to get rid of exceptions in tests for ASSERT().
There was a problem hiding this comment.
I added WithMockAssertNoThrow fixture for this case in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.