8000 refactor: Simplify CMakeLists.txt for sanitizers by mathbunnyru · Pull Request #2297 · XRPLF/clio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: Simplify CMakeLists.txt for sanitizers #2297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
+5 −6
Open

refactor: Simplify CMakeLists.txt for sanitizers #2297

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e111bc3
refactor: Simplify CMakeLists.txt for sanitizers
mathbunnyru Jul 7, 2025
df4ab81
Merge branch 'develop' into san_cmake
mathbunnyru Jul 8, 2025
1a12bef
Merge branch 'develop' into san_cmake
mathbunnyru Jul 8, 2025
e761c14
Merge branch 'develop' into san_cmake
mathbunnyru Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,15 +69,14 @@ endif ()
# Enable selected sanitizer if enabled via `san`
if (san)
set(SUPPORTED_SANITIZERS "address" "thread" "memory" "undefined")
list(FIND SUPPORTED_SANITIZERS "${san}" INDEX)
if (INDEX EQUAL -1)
if (NOT san IN_LIST SUPPORTED_SANITIZERS)
message(FATAL_ERROR "Error: Unsupported sanitizer '${san}'. Supported values are: ${SUPPORTED_SANITIZERS}.")
endif ()

target_compile_options(
clio_options INTERFACE # Sanitizers recommend minimum of -O1 for reasonable performance
$<$<CONFIG:Debug>:-O1> ${SAN_FLAG} -fno-omit-frame-pointer
)
# Sanitizers recommend minimum of -O1 for reasonable performance so we enable it for debug builds
target_compile_options(clio_options INTERFACE $<$<CONFIG:Debug>:-O1>)
target_compile_options(clio_options INTERFACE ${SAN_FLAG} -fno-omit-frame-pointer)
Comment on lines +77 to +78
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think one target_compile_options() with longer list of options is more readable

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion it's not readable at all, because one of them contains an implicit if statement.
In any programming language besides cmake it would have been a separate statement under if 😄

Copy link
Collaborator Author
@mathbunnyru mathbunnyru Jul 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the comment now applies to the whole next line as it should.
Before it applies to a prefix of the next line, which is also not nice


target_compile_definitions(
clio_options INTERFACE $<$<STREQUAL:${san},address>:SANITIZER=ASAN> $<$<STREQUAL:${san},thread>:SANITIZER=TSAN>
$<$<STREQUAL:${san},memory>:SANITIZER=MSAN> $<$<STREQUAL:${san},undefined>:SANITIZER=UBSAN>
Expand Down
0