8000 fix: Errors consistency in LedgerEntry::parsePermissionedDomains() by kuznetsss · Pull Request #5252 · XRPLF/rippled · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Errors consistency in LedgerEntry::parsePermissionedDomains() #5252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2025
Merged

fix: Errors consistency in LedgerEntry::parsePermissionedDomains() #5252

merged 1 commit into from
Jan 21, 2025

Conversation

kuznetsss
Copy link
Contributor

High Level Overview of Change

Update errors for parsing permissioned domains in LedgerEntry handler to make them consistent with other parsers.

Context of Change

The inconsistency this PR is fixing was introduced here: #5161

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

The PR is changing behaviour of the new feature which hasn't got into any release yet.

@Bronek Bronek requested review from oleks-rip and mvadari January 20, 2025 15:46
godexsoft
godexsoft approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator
@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@Bronek Bronek added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Jan 21, 2025
@bthomee bthomee merged commit eac3abd into XRPLF:develop Jan 21, 2025
19 checks passed
@kuznetsss kuznetsss 9E73 deleted the Fix_ledger_entry_errors branch January 22, 2025 11:16
@kuznetsss kuznetsss mentioned this pull request Jan 22, 2025
Merged
q73zhao pushed a commit that referenced this pull request Feb 24, 2025
@kuznetsss @q73zhao
fix: Error consistency in LedgerEntry::parsePermissionedDomains() (#5252
1718790 
)

Update errors for parsing permissioned domains in the LedgerEntry handler to make them consistent with other parsers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godexsoft godexsoft godexsoft approved these changes

@Bronek Bronek Bronek approved these changes

@oleks-rip oleks-rip Awaiting requested review from oleks-rip

@mvadari mvadari Awaiting requested review from mvadari

Assignees
No one assigned
Labels
Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kuznetsss @godexsoft @Bronek @bthomee
0