10000 Fix: XRPAmount Overflow by dangell7 · Pull Request #5330 · XRPLF/rippled · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: XRPAmount Overflow #5330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix: XRPAmount Overflow #5330

wants to merge 3 commits into from
+56 −8

Conversation

dangell7
Copy link
Collaborator
@dangell7 dangell7 commented Mar 4, 2025 •
edited
Loading

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@codecov Codecov
Copy link
codecov bot commented Mar 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.25000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.1%. Comparing base (d22a505) to head (0d0dda9).
Report is 62 commits behind head on develop.

Files with missing lines Patch % Lines
include/xrpl/protocol/XRPAmount.h 81.2% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5330   +/-   ##
=======================================
  Coverage     78.1%   78.1%           
=======================================
  Files          790     790           
  Lines        67988   68013   +25     
  Branches      8255    8260    +5     
=======================================
+ Hits         53084   53104   +20     
- Misses       14904   14909    +5
Files with missing lines Coverage Δ
include/xrpl/protocol/XRPAmount.h 93.8% <81.2%> (-5.1%) ⬇️

... and 3 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Bronek
8000
Copy link
Collaborator
Bronek commented Mar 4, 2025

@dangell7 Find a Windows equivalent and use as appropriate, please

@dangell7 dangell7 force-pushed the xrp-amount-overflow branch from 6cbfa62 to b45a368 Compare March 4, 2025 13:14
@dangell7 dangell7 force-pushed the xrp-amount-overflow branch from b45a368 to 9ab0de2 Compare March 4, 2025 13:18
@dangell7 dangell7 marked this pull request as ready for review April 2, 2025 13:33
@bthomee bthomee requested review from Bronek and vlntb June 6, 2025 15:04
@Bronek
Copy link
Collaborator
Bronek commented Jun 6, 2025

Can you pls also increase the unit test coverage here ? No need to go through Env , just create XRPAmount with inputs to cover all the interesting cases.

This aside this looks good to me.

@bthomee bthomee added the Blocked on requested changes Reviewers have requested changes which must be addressed or responded to label Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bronek Bronek Awaiting requested review from Bronek

@vlntb vlntb Awaiting requested review from vlntb

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Blocked on requested changes Reviewers have requested changes which must be addressed or responded to
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dangell7 @Bronek @bthomee
0