DRAFT: rabbit hole: refactor dirAdd to find gaps in "full" directories. #5362

ximinez · 2025-03-21T23:59:20Z

I was looking at how dirAdd works. There have been complaints that when an account's directory gets "full", it is very difficult to free it back up, even though there may be many many partial pages, and many gaps in the linked list of directories.

This would potentially be very expensive to implement, so don't.
However, it might be a good start for a ledger fix option.

High Level Overview of Change

Context of Change

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Refactor (non-breaking change that only restructures code)
Performance (increase or change in throughput and/or latency)
Tests (you added tests for code that already exists, or your new feature included in this PR)
Documentation update
Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
Release

API Impact

Public API: New feature (new methods and/or new fields)
Public API: Breaking change (in general, breaking changes should only impact the next api_version)
libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
Peer protocol change (must be backward compatible or bump the peer protocol version)

codecov · 2025-03-24T23:05:00Z

Codecov Report

Attention: Patch coverage is 70.42254% with 21 lines in your changes missing coverage. Please review.

Project coverage is 78.1%. Comparing base (1c99ea2) to head (50363f2).

Files with missing lines	Patch %	Lines
src/xrpld/ledger/detail/ApplyView.cpp	70.4%	21 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #5362     +/-   ##
=========================================
- Coverage     78.1%   78.1%   -0.0%     
=========================================
  Files          795     795             
  Lines        68598   68634     +36     
  Branches      8281    8289      +8     
=========================================
+ Hits         53584   53602     +18     
- Misses       15014   15032     +18

Files with missing lines	Coverage Δ
src/xrpld/ledger/detail/ApplyView.cpp	`66.8% <70.4%> (-4.3%)`	⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Takes a page from #5362, which may turn out to be useful!

- Add the LendingProtocol amendment - Add Loan Broker and Loan ledger objects: - Also add new SFields, Keylet functions, and an Invariant to verify no illegal field modification - Update list of "constant" fields from spec - Also add a general check for all object types for the type and index fields - refactor: Check transaction flags in preflight0 - Adds a flagMask parameter to preflight1 so that it's impossible to forget to check flags. - Also adds a short hash prefix to all Transactor log messages. - refactor: Generalize Transactor preflight: - Derived classes no longer need to explicitly check amendments, nor call into preflight1 or preflight2. - implemeng LoanBrokerSet - Transactions: LoanDelete, LoanManage, LoanDraw, LoanPay - LoanBrokerSet creation mostly done. Need update. - Also added a lookup table for pseudo account fields. - Update changed field name. - Modify modifiable fields in an update. Note there are only two. - Add a node field to dirLink, defaulting sfOwnerNode, so other relationships can be updated. - Create some helper classes for transaction fields - Test that they work by converting some of the existing classes - Finish creating helper classes for JTx fields - Also change the pseudo account field lookup to a function that uses a switch - Update tests, update pseudo-account checking - Generalize some of the Invariant checks using macro files - Valid ledger entry type - Valid new account root and pseudo account check - Enumerate transaction privileges for invariants - Allows them to be defined in transactions.macro instead of needing to scrutinize every existing Invariant class. - List is not necessarily comprehensive, but does cover every check where more than one transaction type is involved. - Reserve a few values between Vault and Lending for future use - Pseudo-account improvements - Define pseudo-account fields with an sfield flag - Pseudo-account invariant checks rules whenever a pseudo-account is created or modified. - Move some helper functions. - Check the regular key in the pseudo-transaction invariant check. - Transactor::checkSign will always fail for a pseudo-account, so even if someone figures out how to get a good signature, it won't work. - Fix account creation to check both amendments - Add a validity range for sfDebtMaximum - Change more "failed" messages. The goal here is to be able to search the log for "failed" and ONLY get test failures. - NoModifiedUnmodifiableFields and ValidPseudoAccounts - Move the Invariants_test class into the test namespace - Clang wants an explicit ctor to emplace in a vector - Refactor: Add a Transactor base function to make it easier to get the owner reserve increment as a fee. - Refactor: Add an overload jtx::fee(increment) to pay an owner reserve. - Initial implementation of LoanBrokerDelete - Generalize the LoanBroker lifecycle test - Refactor ApplyView::dirAdd to give access to low-level operations - Takes a page from #5362, which may turn out to be useful! - Start writing Loan Broker invariants and tests - Specifically those mentioned for LoanBrokerDelete - Move all detail namespaces to be under ripple - Avoids problems with namespace collisions / ambiguous symbol issues with unity builds, especially when adding or removing files. - Add LoanBrokerCoverDeposit transaction - Add LoanBrokerCoverWithdraw transaction - Start writing tests for LoanBrokerCover* - Add support for `Asset` and `MPTIssue` to some `jtx` helper classes and functions (`balance`, `expectLine`) - Add support for pseudo-accounts to `jtx::Account` by allowing directly setting the AccountID without a matching key. - Add Asset and MPTIssue support to more jtx objects / functions - Unfortunately, to work around some ambiguous symbol compilation errors, I had to change the implicit conversion from IOU to Asset to a conversion from IOU to PrettyAsset, and add a more explicit `asset()` function. This workaround only required changing two existing tests, so seems acceptable. - Ensure that an account is not deleted with an XRP balance - Updates the AccountRootsDeletedClean invariant - Finish up the Loan Broker tests - Move inclusion of Transactor headers to transactions.macro - Only need to update in one place when adding a new transaction. - Start implementing LoanSet transactor - Add some more values and functions to make it easier to work with basis point values / bips. - Fix several earlier mistakes. - Generalize the check*Sign functions to support CounterParty - checkSign, checkSingleSign, and checkMultiSign in STTx and Transactor - Start writing Loan tests - Required adding support for counterparty signature to jtx framework: arbitrary signature field destination, multiple signer callbacks - Get Counterparty signing working - Add more LoanSet unit tests, added LoanBroker LoanSequence field - LoanSequence will prevent loan key collisions - Change Loan object indexing, fix several broken LoanSet unit tests - Loan objects will now only be indexed by LoanBrokerID and LoanSequence, which is a new field in LoanBroker. Also changes Loan.Sequence to Loan.LoanSequence to match up. - Several tests weren't working because of `PrettyAsset` scaling. Also, `PrettyAsset` calculations could overflow. Made that less likely by changing the type of `scale_`. - LoanSet will fail if an account tries to loan to itself. - Ensure that an account is not deleted with a non-zero owner count - Updates the AccountRootsDeletedClean invariant - Add unit tests to create a Loan successfully - Fix a few field initializations in LoanSet - Refactor issuance validity check in VaultCreate - Utility function: canAddHolding - Call canAddHolding from any transactor that call addEmptyHolding (LoanBrokerSet, LoanSet) - Start implementing LoanManage transaction - Also add a ValidLoan invariant - Finish `LoanManage` functionality and tests, modulo LoanDraw/Pay - Allow existing trust lines to loan brokers to be managed (by issuer) - Implement LoanDelete, and fix a bunch of math errors in LoanManage - Update to match latest spec: compute interest, LoanBroker reserves - refactor: Define getFlagsMask in the base Transactor class - Returns tfUniversalMask for most transactors - Only transactors that use other flags need to override - Implement LoanDraw, and made good progress on related tests - Start implementing LoanPay transaction - Implement LoanPay - Also add an XRPL_ASSERT2, which splits the parts of the assert message so I don't have to remember the proper formatting.

- Add the LendingProtocol amendment - Add Loan Broker and Loan ledger objects: - Also add new SFields, Keylet functions, and an Invariant to verify no illegal field modification - Update list of "constant" fields from spec - Also add a general check for all object types for the type and index fields - refactor: Check transaction flags in preflight0 - Adds a flagMask parameter to preflight1 so that it's impossible to forget to check flags. - Also adds a short hash prefix to all Transactor log messages. - refactor: Generalize Transactor preflight: - Derived classes no longer need to explicitly check amendments, nor call into preflight1 or preflight2. - implemeng LoanBrokerSet - Transactions: LoanDelete, LoanManage, LoanDraw, LoanPay - LoanBrokerSet creation mostly done. Need update. - Also added a lookup table for pseudo account fields. - Update changed field name. - Modify modifiable fields in an update. Note there are only two. - Add a node field to dirLink, defaulting sfOwnerNode, so other relationships can be updated. - Create some helper classes for transaction fields - Test that they work by converting some of the existing classes - Finish creating helper classes for JTx fields - Also change the pseudo account field lookup to a function that uses a switch - Update tests, update pseudo-account checking - Generalize some of the Invariant checks using macro files - Valid ledger entry type - Valid new account root and pseudo account check - Enumerate transaction privileges for invariants - Allows them to be defined in transactions.macro instead of needing to scrutinize every existing Invariant class. - List is not necessarily comprehensive, but does cover every check where more than one transaction type is involved. - Reserve a few values between Vault and Lending for future use - Pseudo-account improvements - Define pseudo-account fields with an sfield flag - Pseudo-account invariant checks rules whenever a pseudo-account is created or modified. - Move some helper functions. - Check the regular key in the pseudo-transaction invariant check. - Transactor::checkSign will always fail for a pseudo-account, so even if someone figures out how to get a good signature, it won't work. - Fix account creation to check both amendments - Add a validity range for sfDebtMaximum - Change more "failed" messages. The goal here is to be able to search the log for "failed" and ONLY get test failures. - NoModifiedUnmodifiableFields and ValidPseudoAccounts - Move the Invariants_test class into the test namespace - Clang wants an explicit ctor to emplace in a vector - Refactor: Add a Transactor base function to make it easier to get the owner reserve increment as a fee. - Refactor: Add an overload jtx::fee(increment) to pay an owner reserve. - Initial implementation of LoanBrokerDelete - Generalize the LoanBroker lifecycle test - Refactor ApplyView::dirAdd to give access to low-level operations - Takes a page from #5362, which may turn out to be useful! - Start writing Loan Broker invariants and tests - Specifically those mentioned for LoanBrokerDelete - Move all detail namespaces to be under ripple - Avoids problems with namespace collisions / ambiguous symbol issues with unity builds, especially when adding or removing files. - Add LoanBrokerCoverDeposit transaction - Add LoanBrokerCoverWithdraw transaction - Start writing tests for LoanBrokerCover* - Add support for `Asset` and `MPTIssue` to some `jtx` helper classes and functions (`balance`, `expectLine`) - Add support for pseudo-accounts to `jtx::Account` by allowing directly setting the AccountID without a matching key. - Add Asset and MPTIssue support to more jtx objects / functions - Unfortunately, to work around some ambiguous symbol compilation errors, I had to change the implicit conversion from IOU to Asset to a conversion from IOU to PrettyAsset, and add a more explicit `asset()` function. This workaround only required changing two existing tests, so seems acceptable. - Ensure that an account is not deleted with an XRP balance - Updates the AccountRootsDeletedClean invariant - Finish up the Loan Broker tests - Move inclusion of Transactor headers to transactions.macro - Only need to update in one place when adding a new transaction. - Start implementing LoanSet transactor - Add some more values and functions to make it easier to work with basis point values / bips. - Fix several earlier mistakes. - Generalize the check*Sign functions to support CounterParty - checkSign, checkSingleSign, and checkMultiSign in STTx and Transactor - Start writing Loan tests - Required adding support for counterparty signature to jtx framework: arbitrary signature field destination, multiple signer callbacks - Get Counterparty signing working - Add more LoanSet unit tests, added LoanBroker LoanSequence field - LoanSequence will prevent loan key collisions - Change Loan object indexing, fix several broken LoanSet unit tests - Loan objects will now only be indexed by LoanBrokerID and LoanSequence, which is a new field in LoanBroker. Also changes Loan.Sequence to Loan.LoanSequence to match up. - Several tests weren't working because of `PrettyAsset` scaling. Also, `PrettyAsset` calculations could overflow. Made that less likely by changing the type of `scale_`. - LoanSet will fail if an account tries to loan to itself. - Ensure that an account is not deleted with a non-zero owner count - Updates the AccountRootsDeletedClean invariant - Add unit tests to create a Loan successfully - Fix a few field initializations in LoanSet - Refactor issuance validity check in VaultCreate - Utility function: canAddHolding - Call canAddHolding from any transactor that call addEmptyHolding (LoanBrokerSet, LoanSet) - Start implementing LoanManage transaction - Also add a ValidLoan invariant - Finish `LoanManage` functionality and tests, modulo LoanDraw/Pay - Allow existing trust lines to loan brokers to be managed (by issuer) - Implement LoanDelete, and fix a bunch of math errors in LoanManage - Update to match latest spec: compute interest, LoanBroker reserves - refactor: Define getFlagsMask in the base Transactor class - Returns tfUniversalMask for most transactors - Only transactors that use other flags need to override - Implement LoanDraw, and made good progress on related tests - Start implementing LoanPay transaction - Implement LoanPay & most tests - Also add an XRPL_ASSERT_PARTS, which splits the parts of the assert message so I don't have to remember the proper formatting. Start writing LoanPay transaction tests

- Add the LendingProtocol amendment - Add Loan Broker and Loan ledger objects: - Also add new SFields, Keylet functions, and an Invariant to verify no illegal field modification - Update list of "constant" fields from spec - Also add a general check for all object types for the type and index fields - refactor: Check transaction flags in preflight0 - Adds a flagMask parameter to preflight1 so that it's impossible to forget to check flags. - Also adds a short hash prefix to all Transactor log messages. - refactor: Generalize Transactor preflight: - Derived classes no longer need to explicitly check amendments, nor call into preflight1 or preflight2. - implemeng LoanBrokerSet - Transactions: LoanDelete, LoanManage, LoanDraw, LoanPay - LoanBrokerSet creation mostly done. Need update. - Also added a lookup table for pseudo account fields. - Update changed field name. - Modify modifiable fields in an update. Note there are only two. - Add a node field to dirLink, defaulting sfOwnerNode, so other relationships can be updated. - Create some helper classes for transaction fields - Test that they work by converting some of the existing classes - Finish creating helper classes for JTx fields - Also change the pseudo account field lookup to a function that uses a switch - Update tests, update pseudo-account checking - Generalize some of the Invariant checks using macro files - Valid ledger entry type - Valid new account root and pseudo account check - Enumerate transaction privileges for invariants - Allows them to be defined in transactions.macro instead of needing to scrutinize every existing Invariant class. - List is not necessarily comprehensive, but does cover every check where more than one transaction type is involved. - Reserve a few values between Vault and Lending for future use - Pseudo-account improvements - Define pseudo-account fields with an sfield flag - Pseudo-account invariant checks rules whenever a pseudo-account is created or modified. - Move some helper functions. - Check the regular key in the pseudo-transaction invariant check. - Transactor::checkSign will always fail for a pseudo-account, so even if someone figures out how to get a good signature, it won't work. - Fix account creation to check both amendments - Add a validity range for sfDebtMaximum - Change more "failed" messages. The goal here is to be able to search the log for "failed" and ONLY get test failures. - NoModifiedUnmodifiableFields and ValidPseudoAccounts - Move the Invariants_test class into the test namespace - Clang wants an explicit ctor to emplace in a vector - Refactor: Add a Transactor base function to make it easier to get the owner reserve increment as a fee. - Refactor: Add an overload jtx::fee(increment) to pay an owner reserve. - Initial implementation of LoanBrokerDelete - Generalize the LoanBroker lifecycle test - Refactor ApplyView::dirAdd to give access to low-level operations - Takes a page from #5362, which may turn out to be useful! - Start writing Loan Broker invariants and tests - Specifically those mentioned for LoanBrokerDelete - Move all detail namespaces to be under ripple - Avoids problems with namespace collisions / ambiguous symbol issues with unity builds, especially when adding or removing files. - Add LoanBrokerCoverDeposit transaction - Add LoanBrokerCoverWithdraw transaction - Start writing tests for LoanBrokerCover* - Add support for `Asset` and `MPTIssue` to some `jtx` helper classes and functions (`balance`, `expectLine`) - Add support for pseudo-accounts to `jtx::Account` by allowing directly setting the AccountID without a matching key. - Add Asset and MPTIssue support to more jtx objects / functions - Unfortunately, to work around some ambiguous symbol compilation errors, I had to change the implicit conversion from IOU to Asset to a con E29B version from IOU to PrettyAsset, and add a more explicit `asset()` function. This workaround only required changing two existing tests, so seems acceptable. - Ensure that an account is not deleted with an XRP balance - Updates the AccountRootsDeletedClean invariant - Finish up the Loan Broker tests - Move inclusion of Transactor headers to transactions.macro - Only need to update in one place when adding a new transaction. - Start implementing LoanSet transactor - Add some more values and functions to make it easier to work with basis point values / bips. - Fix several earlier mistakes. - Generalize the check*Sign functions to support CounterParty - checkSign, checkSingleSign, and checkMultiSign in STTx and Transactor - Start writing Loan tests - Required adding support for counterparty signature to jtx framework: arbitrary signature field destination, multiple signer callbacks - Get Counterparty signing working - Add more LoanSet unit tests, added LoanBroker LoanSequence field - LoanSequence will prevent loan key collisions - Change Loan object indexing, fix several broken LoanSet unit tests - Loan objects will now only be indexed by LoanBrokerID and LoanSequence, which is a new field in LoanBroker. Also changes Loan.Sequence to Loan.LoanSequence to match up. - Several tests weren't working because of `PrettyAsset` scaling. Also, `PrettyAsset` calculations could overflow. Made that less likely by changing the type of `scale_`. - LoanSet will fail if an account tries to loan to itself. - Ensure that an account is not deleted with a non-zero owner count - Updates the AccountRootsDeletedClean invariant - Add unit tests to create a Loan successfully - Fix a few field initializations in LoanSet - Refactor issuance validity check in VaultCreate - Utility function: canAddHolding - Call canAddHolding from any transactor that call addEmptyHolding (LoanBrokerSet, LoanSet) - Start implementing LoanManage transaction - Also add a ValidLoan invariant - Finish `LoanManage` functionality and tests, modulo LoanDraw/Pay - Allow existing trust lines to loan brokers to be managed (by issuer) - Implement LoanDelete, and fix a bunch of math errors in LoanManage - Update to match latest spec: compute interest, LoanBroker reserves - refactor: Define getFlagsMask in the base Transactor class - Returns tfUniversalMask for most transactors - Only transactors that use other flags need to override - Implement LoanDraw, and made good progress on related tests - Start implementing LoanPay transaction - Implement LoanPay & most tests - Also add an XRPL_ASSERT_PARTS, which splits the parts of the assert message so I don't have to remember the proper formatting. Start writing LoanPay transaction tests

- Add the LendingProtocol amendment - Add Loan Broker and Loan ledger objects: - Also add new SFields, Keylet functions, and an Invariant to verify no illegal field modification - Update list of "constant" fields from spec - Also add a general check for all object types for the type and index fields - refactor: Check transaction flags in preflight0 - Adds a flagMask parameter to preflight1 so that it's impossible to forget to check flags. - Also adds a short hash prefix to all Transactor log messages. - refactor: Generalize Transactor preflight: - Derived classes no longer need to explicitly check amendments, nor call into preflight1 or preflight2. - implemeng LoanBrokerSet - Transactions: LoanDelete, LoanManage, LoanDraw, LoanPay - LoanBrokerSet creation mostly done. Need update. - Also added a lookup table for pseudo account fields. - Update changed field name. - Modify modifiable fields in an update. Note there are only two. - Add a node field to dirLink, defaulting sfOwnerNode, so other relationships can be updated. - Create some helper classes for transaction fields - Test that they work by converting some of the existing classes - Finish creating helper classes for JTx fields - Also change the pseudo account field lookup to a function that uses a switch - Update tests, update pseudo-account checking - Generalize some of the Invariant checks using macro files - Valid ledger entry type - Valid new account root and pseudo account check - Enumerate transaction privileges for invariants - Allows them to be defined in transactions.macro instead of needing to scrutinize every existing Invariant class. - List is not necessarily comprehensive, but does cover every check where more than one transaction type is involved. - Reserve a few values between Vault and Lending for future use - Pseudo-account improvements - Define pseudo-account fields with an sfield flag - Pseudo-account invariant checks rules whenever a pseudo-account is created or modified. - Move some helper functions. - Check the regular key in the pseudo-transaction invariant check. - Transactor::checkSign will always fail for a pseudo-account, so even if someone figures out how to get a good signature, it won't work. - Fix account creation to check both amendments - Add a validity range for sfDebtMaximum - Change more "failed" messages. The goal here is to be able to search the log for "failed" and ONLY get test failures. - NoModifiedUnmodifiableFields and ValidPseudoAccounts - Move the Invariants_test class into the test namespace - Clang wants an explicit ctor to emplace in a vector - Refactor: Add a Transactor base function to make it easier to get the owner reserve increment as a fee. - Refactor: Add an overload jtx::fee(increment) to pay an owner reserve. - Initial implementation of LoanBrokerDelete - Generalize the LoanBroker lifecycle test - Refactor ApplyView::dirAdd to give access to low-level operations - Takes a page from #5362, which may turn out to be useful! - Start writing Loan Broker invariants and tests - Specifically those mentioned for LoanBrokerDelete - Move all detail namespaces to be under ripple - Avoids problems with namespace collisions / ambiguous symbol issues with unity builds, especially when adding or removing files. - Add LoanBrokerCoverDeposit transaction - Add LoanBrokerCoverWithdraw transaction - Start writing tests for LoanBrokerCover* - Add support for `Asset` and `MPTIssue` to some `jtx` helper classes and functions (`balance`, `expectLine`) - Add support for pseudo-accounts to `jtx::Account` by allowing directly setting the AccountID without a matching key. - Add Asset and MPTIssue support to more jtx objects / functions - Unfortunately, to work around some ambiguous symbol compilation errors, I had to change the implicit conversion from IOU to Asset to a conversion from IOU to PrettyAsset, and add a more explicit `asset()` function. This workaround only required changing two existing tests, so seems acceptable. - Ensure that an account is not deleted with an XRP balance - Updates the AccountRootsDeletedClean invariant - Finish up the Loan Broker tests - Move inclusion of Transactor headers to transactions.macro - Only need to update in one place when adding a new transaction. - Start implementing LoanSet transactor - Add some more values and functions to make it easier to work with basis point values / bips. - Fix several earlier mistakes. - Generalize the check*Sign functions to support CounterParty - checkSign, checkSingleSign, and checkMultiSign in STTx and Transactor - Start writing Loan tests - Required adding support for counterparty signature to jtx framework: arbitrary signature field destination, multiple signer callbacks - Get Counterparty signing working - Add more LoanSet unit tests, added LoanBroker LoanSequence field - LoanSequence will prevent loan key collisions - Change Loan object indexing, fix several broken LoanSet unit tests - Loan objects will now only be indexed by LoanBrokerID and LoanSequence, which is a new field in LoanBroker. Also changes Loan.Sequence to Loan.LoanSequence to match up. - Several tests weren't working because of `PrettyAsset` scaling. Also, `PrettyAsset` calculations could overflow. Made that less likely by changing the type of `scale_`. - LoanSet will fail if an account tries to loan to itself. - Ensure that an account is not deleted with a non-zero owner count - Updates the AccountRootsDeletedClean invariant - Add unit tests to create a Loan successfully - Fix a few field initializations in LoanSet - Refactor issuance validity check in VaultCreate - Utility function: canAddHolding - Call canAddHolding from any transactor that call addEmptyHolding (LoanBrokerSet, LoanSet) - Start implementing LoanManage transaction - Also add a ValidLoan invariant - Finish `LoanManage` functionality and tests, modulo LoanDraw/Pay - Allow existing trust lines to loan brokers to be managed (by issuer) - Implement LoanDelete, and fix a bunch of math errors in LoanManage - Update to match latest spec: compute interest, LoanBroker reserves - refactor: Define getFlagsMask in the base Transactor class - Returns tfUniversalMask for most transactors - Only transactors that use other flags need to override - Implement LoanDraw, and made good progress on related tests - Start implementing LoanPay transaction - Implement LoanPay & most tests - Also add an XRPL_ASSERT_PARTS, which splits the parts of the assert message so I don't have to remember the proper formatting. Start writing LoanPay transaction tests

- Add the LendingProtocol amendment - Add Loan Broker and Loan ledger objects: - Also add new SFields, Keylet functions, and an Invariant to verify no illegal field modification - Update list of "constant" fields from spec - Also add a general check for all object types for the type and index fields - refactor: Check transaction flags in preflight0 - Adds a flagMask parameter to preflight1 so that it's impossible to forget to check flags. - Also adds a short hash prefix to all Transactor log messages. - refactor: Generalize Transactor preflight: - Derived classes no longer need to explicitly check amendments, nor call into preflight1 or preflight2. - implemeng LoanBrokerSet - Transactions: LoanDelete, LoanManage, LoanDraw, LoanPay - LoanBrokerSet creation mostly done. Need update. - Also added a lookup table for pseudo account fields. - Update changed field name. - Modify modifiable fields in an update. Note there are only two. - Add a node field to dirLink, defaulting sfOwnerNode, so other relationships can be updated. - Create some helper classes for transaction fields - Test that they work by converting some of the existing classes - Finish creating helper classes for JTx fields - Also change the pseudo account field lookup to a function that uses a switch - Update tests, update pseudo-account checking - Generalize some of the Invariant checks using macro files - Valid ledger entry type - Valid new account root and pseudo account check - Enumerate transaction privileges for invariants - Allows them to be defined in transactions.macro instead of needing to scrutinize every existing Invariant class. - List is not necessarily comprehensive, but does cover every check where more than one transaction type is involved. - Reserve a few values between Vault and Lending for future use - Pseudo-account improvements - Define pseudo-account fields with an sfield flag - Pseudo-account invariant checks rules whenever a pseudo-account is created or modified. - Move some helper functions. - Check the regular key in the pseudo-transaction invariant check. - Transactor::checkSign will always fail for a pseudo-account, so even if someone figures out how to get a good signature, it won't work. - Fix account creation to check both amendments - Add a validity range for sfDebtMaximum - Change more "failed" messages. The goal here is to be able to search the log for "failed" and ONLY get test failures. - NoModifiedUnmodifiableFields and ValidPseudoAccounts - Move the Invariants_test class into the test namespace - Clang wants an explicit ctor to emplace in a vector - Refactor: Add a Transactor base function to make it easier to get the owner reserve increment as a fee. - Refactor: Add an overload jtx::fee(increment) to pay an owner reserve. - Initial implementation of LoanBrokerDelete - Generalize the LoanBroker lifecycle test - Refactor ApplyView::dirAdd to give access to low-level operations - Takes a page from #5362, which may turn out to be useful! - Start writing Loan Broker invariants and tests - Specifically those mentioned for LoanBrokerDelete - Move all detail namespaces to be under ripple - Avoids problems with namespace collisions / ambiguous symbol issues with unity builds, especially when adding or removing files. - Add LoanBrokerCoverDeposit transaction - Add LoanBrokerCoverWithdraw transaction - Start writing tests for LoanBrokerCover* - Add support for `Asset` and `MPTIssue` to some `jtx` helper classes and functions (`balance`, `expectLine`) - Add support for pseudo-accounts to `jtx::Account` by allowing directly setting the AccountID without a matching key. - Add Asset and MPTIssue support to more jtx objects / functions - Unfortunately, to work around some ambiguous symbol compilation errors, I had to change the implicit conversion from IOU to Asset to a conversion from IOU to PrettyAsset, and add a more explicit `asset()` function. This workaround only required changing two existing tests, so seems acceptable. - Ensure that an account is not deleted with an XRP balance - Updates the AccountRootsDeletedClean invariant - Finish up the Loan Broker tests - Move inclusion of Transactor headers to transactions.macro - Only need to update in one place when adding a new transaction. - Start implementing LoanSet transactor - Add some more values and functions to make it easier to work with basis point values / bips. - Fix several earlier mistakes. - Generalize the check*Sign functions to support CounterParty - checkSign, checkSingleSign, and checkMultiSign in STTx and Transactor - Start writing Loan tests - Required adding support for counterparty signature to jtx framework: arbitrary signature field destination, multiple signer callbacks - Get Counterparty signing working - Add more LoanSet unit tests, added LoanBroker LoanSequence field - LoanSequence will prevent loan key collisions - Change Loan object indexing, fix several broken LoanSet unit tests - Loan objects will now only be indexed by LoanBrokerID and LoanSequence, which is a new field in LoanBroker. Also changes Loan.Sequence to Loan.LoanSequence to match up. - Several tests weren't working because of `PrettyAsset` scaling. Also, `PrettyAsset` calculations could overflow. Made that less likely by changing the type of `scale_`. - LoanSet will fail if an account tries to loan to itself. - Ensure that an account is not deleted with a non-zero owner count - Updates the AccountRootsDeletedClean invariant - Add unit tests to create a Loan successfully - Fix a few field initializations in LoanSet - Refactor issuance validity check in VaultCreate - Utility function: canAddHolding - Call canAddHolding from any transactor that call addEmptyHolding (LoanBrokerSet, LoanSet) - Start implementing LoanManage transaction - Also add a ValidLoan invariant - Finish `LoanManage` functionality and tests, modulo LoanDra 292D w/Pay - Allow existing trust lines to loan brokers to be managed (by issuer) - Implement LoanDelete, and fix a bunch of math errors in LoanManage - Update to match latest spec: compute interest, LoanBroker reserves - refactor: Define getFlagsMask in the base Transactor class - Returns tfUniversalMask for most transactors - Only transactors that use other flags need to override - Implement LoanDraw, and made good progress on related tests - Start implementing LoanPay transaction - Implement LoanPay & most tests - Also add an XRPL_ASSERT_PARTS, which splits the parts of the assert message so I don't have to remember the proper formatting. Start writing LoanPay transaction tests

- Add the LendingProtocol amendment - Add Loan Broker and Loan ledger objects: - Also add new SFields, Keylet functions, and an Invariant to verify no illegal field modification - Update list of "constant" fields from spec - Also add a general check for all object types for the type and index fields - refactor: Check transaction flags in preflight0 - Adds a flagMask parameter to preflight1 so that it's impossible to forget to check flags. - Also adds a short hash prefix to all Transactor log messages. - refactor: Generalize Transactor preflight: - Derived classes no longer need to explicitly check amendments, nor call into preflight1 or preflight2. - implemeng LoanBrokerSet - Transactions: LoanDelete, LoanManage, LoanDraw, LoanPay - LoanBrokerSet creation mostly done. Need update. - Also added a lookup table for pseudo account fields. - Update changed field name. - Modify modifiable fields in an update. Note there are only two. - Add a node field to dirLink, defaulting sfOwnerNode, so other relationships can be updated. - Create some helper classes for transaction fields - Test that they work by converting some of the existing classes - Finish creating helper classes for JTx fields - Also change the pseudo account field lookup to a function that uses a switch - Update tests, update pseudo-account checking - Generalize some of the Invariant checks using macro files - Valid ledger entry type - Valid new account root and pseudo account check - Enumerate transaction privileges for invariants - Allows them to be defined in transactions.macro instead of needing to scrutinize every existing Invariant class. - List is not necessarily comprehensive, but does cover every check where more than one transaction type is involved. - Reserve a few values between Vault and Lending for future use - Pseudo-account improvements - Define pseudo-account fields with an sfield flag - Pseudo-account invariant checks rules whenever a pseudo-account is created or modified. - Move some helper functions. - Check the regular key in the pseudo-transaction invariant check. - Transactor::checkSign will always fail for a pseudo-account, so even if someone figures out how to get a good signature, it won't work. - Fix account creation to check both amendments - Add a validity range for sfDebtMaximum - Change more "failed" messages. The goal here is to be able to search the log for "failed" and ONLY get test failures. - NoModifiedUnmodifiableFields and ValidPseudoAccounts - Move the Invariants_test class into the test namespace - Clang wants an explicit ctor to emplace in a vector - Refactor: Add a Transactor base function to make it easier to get the owner reserve increment as a fee. - Refactor: Add an overload jtx::fee(increment) to pay an owner reserve. - Initial implementation of LoanBrokerDelete - Generalize the LoanBroker lifecycle test - Refactor ApplyView::dirAdd to give access to low-level operations - Takes a page from #5362, which may turn out to be useful! - Start writing Loan Broker invariants and tests - Specifically those mentioned for LoanBrokerDelete - Move all detail namespaces to be under ripple - Avoids problems with namespace collisions / ambiguous symbol issues with unity builds, especially when adding or removing files. - Add LoanBrokerCoverDeposit transaction - Add LoanBrokerCoverWithdraw transaction - Start writing tests for LoanBrokerCover* - Add support for `Asset` and `MPTIssue` to some `jtx` helper classes and functions (`balance`, `expectLine`) - Add support for pseudo-accounts to `jtx::Account` by allowing directly setting the AccountID without a matching key. - Add Asset and MPTIssue support to more jtx objects / functions - Unfortunately, to work around some ambiguous symbol compilation errors, I had to change the implicit conversion from IOU to Asset to a conversion from IOU to PrettyAsset, and add a more explicit `asset()` function. This workaround only required changing two existing tests, so seems acceptable. - Ensure that an account is not deleted with an XRP balance - Updates the AccountRootsDeletedClean invariant - Finish up the Loan Broker tests - Move inclusion of Transactor headers to transactions.macro - Only need to update in one place when adding a new transaction. - Start implementing LoanSet transactor - Add some more values and functions to make it easier to work with basis point values / bips. - Fix several earlier mistakes. - Generalize the check*Sign functions to support CounterParty - checkSign, checkSingleSign, and checkMultiSign in STTx and Transactor - Start writing Loan tests - Required adding support for counterparty signature to jtx framework: arbitrary signature field destination, multiple signer callbacks - Get Counterparty signing working - Add more LoanSet unit tests, added LoanBroker LoanSequence field - LoanSequence will prevent loan key collisions - Change Loan object indexing, fix several broken LoanSet unit tests - Loan objects will now only be indexed by LoanBrokerID and LoanSequence, which is a new field in LoanBroker. Also changes Loan.Sequence to Loan.LoanSequence to match up. - Several tests weren't working because of `PrettyAsset` scaling. Also, `PrettyAsset` calculations could overflow. Made that less likely by changing the type of `scale_`. - LoanSet will fail if an account tries to loan to itself. - Ensure that an account is not deleted with a non-zero owner count - Updates the AccountRootsDeletedClean invariant - Add unit tests to create a Loan successfully - Fix a few field initializations in LoanSet - Refactor issuance validity check in VaultCreate - Utility function: canAddHolding - Call canAddHolding from any transactor that call addEmptyHolding (LoanBrokerSet, LoanSet) - Start implementing LoanManage transaction - Also add a ValidLoan invariant - Finish `LoanManage` functionality and tests, modulo LoanDraw/Pay - Allow existing trust lines to loan brokers to be managed (by issuer) - Implement LoanDelete, and fix a bunch of math errors in LoanManage - Update to match latest spec: compute interest, LoanBroker reserves - refactor: Define getFlagsMask in the base Transactor class - Returns tfUniversalMask for most transactors - Only transactors that use other flags need to override - Implement LoanDraw, and made good progress on related tests - Start implementing LoanPay transaction - Implement LoanPay & most tests - Also add an XRPL_ASSERT_PARTS, which splits the parts of the assert message so I don't have to remember the proper formatting. Start writing LoanPay transaction tests

- Add the LendingProtocol amendment - Add Loan Broker and Loan ledger objects: - Also add new SFields, Keylet functions, and an Invariant to verify no illegal field modification - Update list of "constant" fields from spec - Also add a general check for all object types for the type and index fields - refactor: Check transaction flags in preflight0 - Adds a flagMask parameter to preflight1 so that it's impossible to forget to check flags. - Also adds a short hash prefix to all Transactor log messages. - refactor: Generalize Transactor preflight: - Derived classes no longer need to explicitly check amendments, nor call into preflight1 or preflight2. - implemeng LoanBrokerSet - Transactions: LoanDelete, LoanManage, LoanDraw, LoanPay - LoanBrokerSet creation mostly done. Need update. - Also added a lookup table for pseudo account fields. - Update changed field name. - Modify modifiable fields in an update. Note there are only two. - Add a node field to dirLink, defaulting sfOwnerNode, so other relationships can be updated. - Create some helper classes for transaction fields - Test that they work by converting some of the existing classes - Finish creating helper classes for JTx fields - Also change the pseudo account field lookup to a function that uses a switch - Update tests, update pseudo-account checking - Generalize some of the Invariant checks using macro files - Valid ledger entry type - Valid new account root and pseudo account check - Enumerate transaction privileges for invariants - Allows them to be defined in transactions.macro instead of needing to scrutinize every existing Invariant class. - List is not necessarily comprehensive, but does cover every check where more than one transaction type is involved. - Reserve a few values between Vault and Lending for future use - Pseudo-account improvements - Define pseudo-account fields with an sfield flag - Pseudo-account invariant checks rules whenever a pseudo-account is created or modified. - Move some helper functions. - Check the regular key in the pseudo-transaction invariant check. - Transactor::checkSign will always fail for a pseudo-account, so even if someone figures out how to get a good signature, it won't work. - Fix account creation to check both amendments - Add a validity range for sfDebtMaximum - Change more "failed" messages. The goal here is to be able to search the log for "failed" and ONLY get test failures. - NoModifiedUnmodifiableFields and ValidPseudoAccounts - Move the Invariants_test class into the test namespace - Clang wants an explicit ctor to emplace in a vector - Refactor: Add a Transactor base function to make it easier to get the owner reserve increment as a fee. - Refactor: Add an overload jtx::fee(increment) to pay an owner reserve. - Initial implementation of LoanBrokerDelete - Generalize the LoanBroker lifecycle test - Refactor ApplyView::dirAdd to give access to low-level operations - Takes a page from #5362, which may turn out to be useful! - Start writing Loan Broker invariants and tests - Specifically those mentioned for LoanBrokerDelete - Move all detail namespaces to be under ripple - Avoids problems with namespace collisions / ambiguous symbol issues with unity builds, especially when adding or removing files. - Add LoanBrokerCoverDeposit transaction - Add LoanBrokerCoverWithdraw transaction - Start writing tests for LoanBrokerCover* - Add support for `Asset` and `MPTIssue` to some `jtx` helper classes and functions (`balance`, `expectLine`) - Add support for pseudo-accounts to `jtx::Account` by allowing directly setting the AccountID without a matching key. - Add Asset and MPTIssue support to more jtx objects / functions - Unfortunately, to work around some ambiguous symbol compilation errors, I had to change the implicit conversion from IOU to Asset to a conversion from IOU to PrettyAsset, and add a more explicit `asset()` function. This workaround only required changing two existing tests, so seems acceptable. - Ensure that an account is not deleted with an XRP balance - Updates the AccountRootsDeletedClean invariant - Finish up the Loan Broker tests - Move inclusion of Transactor headers to transactions.macro - Only need to update in one place when adding a new transaction. - Start implementing LoanSet transactor - Add some more values and functions to make it easier to work with basis point values / bips. - Fix several earlier mistakes. 10000 - Generalize the check*Sign functions to support CounterParty - checkSign, checkSingleSign, and checkMultiSign in STTx and Transactor - Start writing Loan tests - Required adding support for counterparty signature to jtx framework: arbitrary signature field destination, multiple signer callbacks - Get Counterparty signing working - Add more LoanSet unit tests, added LoanBroker LoanSequence field - LoanSequence will prevent loan key collisions - Change Loan object indexing, fix several broken LoanSet unit tests - Loan objects will now only be indexed by LoanBrokerID and LoanSequence, which is a new field in LoanBroker. Also changes Loan.Sequence to Loan.LoanSequence to match up. - Several tests weren't working because of `PrettyAsset` scaling. Also, `PrettyAsset` calculations could overflow. Made that less likely by changing the type of `scale_`. - LoanSet will fail if an account tries to loan to itself. - Ensure that an account is not deleted with a non-zero owner count - Updates the AccountRootsDeletedClean invariant - Add unit tests to create a Loan successfully - Fix a few field initializations in LoanSet - Refactor issuance validity check in VaultCreate - Utility function: canAddHolding - Call canAddHolding from any transactor that call addEmptyHolding (LoanBrokerSet, LoanSet) - Start implementing LoanManage transaction - Also add a ValidLoan invariant - Finish `LoanManage` functionality and tests, modulo LoanDraw/Pay - Allow existing trust lines to loan brokers to be managed (by issuer) - Implement LoanDelete, and fix a bunch of math errors in LoanManage - Update to match latest spec: compute interest, LoanBroker reserves - refactor: Define getFlagsMask in the base Transactor class - Returns tfUniversalMask for most transactors - Only transactors that use other flags need to override - Implement LoanDraw, and made good progress on related tests - Start implementing LoanPay transaction - Implement LoanPay & most tests - Also add an XRPL_ASSERT_PARTS, which splits the parts of the assert message so I don't have to remember the proper formatting. Start writing LoanPay transaction tests

- Add the LendingProtocol amendment - Add Loan Broker and Loan ledger objects: - Also add new SFields, Keylet functions, and an Invariant to verify no illegal field modification - Update list of "constant" fields from spec - Also add a general check for all object types for the type and index fields - refactor: Check transaction flags in preflight0 - Adds a flagMask parameter to preflight1 so that it's impossible to forget to check flags. - Also adds a short hash prefix to all Transactor log messages. - refactor: Generalize Transactor preflight: - Derived classes no longer need to explicitly check amendments, nor call into preflight1 or preflight2. - implemeng LoanBrokerSet - Transactions: LoanDelete, LoanManage, LoanDraw, LoanPay - LoanBrokerSet creation mostly done. Need update. - Also added a lookup table for pseudo account fields. - Update changed field name. - Modify modifiable fields in an update. Note there are only two. - Add a node field to dirLink, defaulting sfOwnerNode, so other relationships can be updated. - Create some helper classes for transaction fields - Test that they work by converting some of the existing classes - Finish creating helper classes for JTx fields - Also change the pseudo account field lookup to a function that uses a switch - Update tests, update pseudo-account checking - Generalize some of the Invariant checks using macro files - Valid ledger entry type - Valid new account root and pseudo account check - Enumerate transaction privileges for invariants - Allows them to be defined in transactions.macro instead of needing to scrutinize every existing Invariant class. - List is not necessarily comprehensive, but does cover every check where more than one transaction type is involved. - Reserve a few values between Vault and Lending for future use - Pseudo-account improvements - Define pseudo-account fields with an sfield flag - Pseudo-account invariant checks rules whenever a pseudo-account is created or modified. - Move some helper functions. - Check the regular key in the pseudo-transaction invariant check. - Transactor::checkSign will always fail for a pseudo-account, so even if someone figures out how to get a good signature, it won't work. - Fix account creation to check both amendments - Add a validity range for sfDebtMaximum - Change more "failed" messages. The goal here is to be able to search the log for "failed" and ONLY get test failures. - NoModifiedUnmodifiableFields and ValidPseudoAccounts - Move the Invariants_test class into the test namespace - Clang wants an explicit ctor to emplace in a vector - Refactor: Add a Transactor base function to make it easier to get the owner reserve increment as a fee. - Refactor: Add an overload jtx::fee(increment) to pay an owner reserve. - Initial implementation of LoanBrokerDelete - Generalize the LoanBroker lifecycle test - Refactor ApplyView::dirAdd to give access to low-level operations - Takes a page from #5362, which may turn out to be useful! - Start writing Loan Broker invariants and tests - Specifically those mentioned for LoanBrokerDelete - Move all detail namespaces to be under ripple - Avoids problems with namespace collisions / ambiguous symbol issues with unity builds, especially when adding or removing files. - Add LoanBrokerCoverDeposit transaction - Add LoanBrokerCoverWithdraw transaction - Start writing tests for LoanBrokerCover* - Add support for `Asset` and `MPTIssue` to some `jtx` helper classes and functions (`balance`, `expectLine`) - Add support for pseudo-accounts to `jtx::Account` by allowing directly setting the AccountID without a matching key. - Add Asset and MPTIssue support to more jtx objects / functions - Unfortunately, to work around some ambiguous symbol compilation errors, I had to change the implicit conversion from IOU to Asset to a conversion from IOU to PrettyAsset, and add a more explicit `asset()` function. This workaround only required changing two existing tests, so seems acceptable. - Ensure that an account is not deleted with an XRP balance - Updates the AccountRootsDeletedClean invariant - Finish up the Loan Broker tests - Move inclusion of Transactor headers to transactions.macro - Only need to update in one place when adding a new transaction. - Start implementing LoanSet transactor - Add some more values and functions to make it easier to work with basis point values / bips. - Fix several earlier mistakes. - Generalize the check*Sign functions to support CounterParty - checkSign, checkSingleSign, and checkMultiSign in STTx and Transactor - Start writing Loan tests - Required adding support for counterparty signature to jtx framework: arbitrary signature field destination, multiple signer callbacks - Get Counterparty signing working - Add more LoanSet unit tests, added LoanBroker LoanSequence field - LoanSequence will prevent loan key collisions - Change Loan object indexing, fix several broken LoanSet unit tests - Loan objects will now only be indexed by LoanBrokerID and LoanSequence, which is a new field in LoanBroker. Also changes Loan.Sequence to Loan.LoanSequence to match up. - Several tests weren't working because of `PrettyAsset` scaling. Also, `PrettyAsset` calculations could overflow. Made that less likely by changing the type of `scale_`. - LoanSet will fail if an account tries to loan to itself. - Ensure that an account is not deleted with a non-zero owner count - Updates the AccountRootsDeletedClean invariant - Add unit tests to create a Loan successfully - Fix a few field initializations in LoanSet - Refactor issuance validity check in VaultCreate - Utility function: canAddHolding - Call canAddHolding from any transactor that call addEmptyHolding (LoanBrokerSet, LoanSet) - Start implementing LoanManage transaction - Also add a ValidLoan invariant - Finish `LoanManage` functionality and tests, modulo LoanDraw/Pay - Allow existing trust lines to loan brokers to be managed (by issuer) - Implement LoanDelete, and fix a bunch of math errors in LoanManage - Update to match latest spec: compute interest, LoanBroker reserves - refactor: Define getFlagsMask in the base Transactor class - Returns tfUniversalMask for most transactors - Only transactors that use other flags need to override - Implement LoanDraw, and made good progress on related tests - Start implementing LoanPay transaction - Implement LoanPay & most tests - Also add an XRPL_ASSERT_PARTS, which splits the parts of the assert message so I don't have to remember the proper formatting. Start writing LoanPay transaction tests

- This would potentially be very expensive to implement, so don't. - However, it might be a good start for a ledger fix option.

ximinez force-pushed the ximinez/directory branch from 79be74d to e8e2895 Compare March 24, 2025 22:43

ximinez force-pushed the ximinez/directory branch 4 times, most recently from 7e95906 to 2f24725 Compare March 31, 2025 21:57

ximinez force-pushed the ximinez/directory branch 4 times, most recently from e68c94b to 937abc6 Compare April 8, 2025 01:16

ximinez force-pushed the ximinez/directory branch 5 times, most recently from 50363f2 to 6cfd981 Compare April 11, 2025 22:30

ximinez added a commit that referenced this pull request Apr 17, 2025

Refactor ApplyView::dirAdd to give access to low-level operations

8791171

- Takes a page from #5362, which may turn out to be useful!

ximinez added a commit that referenced this pull request Apr 23, 2025

Refactor ApplyView::dirAdd to give access to low-level operations

bb4c83d

- Takes a page from #5362, which may turn out to be useful!

ximinez added a commit that referenced this pull request Apr 24, 2025

Refactor ApplyView::dirAdd to give access to low-level operations

5119ef1

- Takes a page from #5362, which may turn out to be useful!

ximinez force-pushed the ximinez/directory branch from 42bc010 to bfcba1b Compare April 24, 2025 14:50

ximinez added a commit that referenced this pull request Apr 24, 2025

Refactor ApplyView::dirAdd to give access to low-level operations

fe90816

- Takes a page from #5362, which may turn out to be useful!

ximinez added a commit that referenced this pull request Apr 28, 2025

Refactor ApplyView::dirAdd to give access to low-level operations

9ba0cc9

- Takes a page from #5362, which may turn out to be useful!

ximinez force-pushed the ximinez/directory branch from bfcba1b to 5811dfc Compare April 28, 2025 18:43

ximinez added a commit that referenced this pull request Apr 29, 2025

Refactor ApplyView::dirAdd to give access to low-level operations

b3b89f2

- Takes a page from #5362, which may turn out to be useful!

ximinez added a commit that referenced this pull request Apr 30, 2025

Refactor ApplyView::dirAdd to give access to low-level operations

89ae726

- Takes a page from #5362, which may turn out to be useful!

ximinez force-pushed the ximinez/directory branch from 5811dfc to 2f0a4cc Compare April 30, 2025 16:02

ximinez added a commit that referenced this pull request Apr 30, 2025

Refactor ApplyView::dirAdd to give access to low-level operations

fb9d0f7

- Takes a page from #5362, which may turn out to be useful!

ximinez added a commit that referenced this pull request May 1, 2025

Refactor ApplyView::dirAdd to give access to low-level operations

d0e792e

- Takes a page from #5362, which may turn out to be useful!

ximinez added a commit that referenced this pull request May 1, 2025

Refactor ApplyView::dirAdd to give access to low-level operations

466a5fa

- Takes a page from #5362, which may turn out to be useful!

ximinez added a commit that referenced this pull request May 5, 2025

Refactor ApplyView::dirAdd to give access to low-level operations

dea6502

- Takes a page from #5362, which may turn out to be useful!

ximinez force-pushed the ximinez/directory branch from 2f0a4cc to e54f8ff Compare May 5, 2025 01:56

ximinez added a commit that referenced this pull request May 5, 2025

Refactor ApplyView::dirAdd to give access to low-level operations

9501b5d

- Takes a page from #5362, which may turn out to be useful!

ximinez added a commit that referenced this pull request May 7, 2025

Refactor ApplyView::dirAdd to give access to low-level operations

7ab5bdb

- Takes a page from #5362, which may turn out to be useful!

ximinez force-pushed the ximinez/directory branch from e54f8ff to 6171285 Compare May 14, 2025 17:01

ximinez added 2 commits July 3, 2025 18:16

rabbit hole: refactor dirAdd to find gaps in "full" directories.

1fb73b0

- This would potentially be very expensive to implement, so don't. - However, it might be a good start for a ledger fix option.

Move the lambdas to be helper functions

5052ac2

ximinez force-pushed the ximinez/directory branch from 6171285 to 5052ac2 Compare July 3, 2025 22:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

DRAFT: rabbit hole: refactor dirAdd to find gaps in "full" directories. #5362

DRAFT: rabbit hole: refactor dirAdd to find gaps in "full" directories. #5362

Uh oh!

Uh oh!

Uh oh!

DRAFT: rabbit hole: refactor dirAdd to find gaps in "full" directories. #5362

Are you sure you want to change the base?

DRAFT: rabbit hole: refactor dirAdd to find gaps in "full" directories. #5362

Conversation

High Level Overview of Change

Context of Change

Type of Change

API Impact

Uh oh!

Uh oh!

Codecov Report

Uh oh!

Uh oh!