8000 Host function gas cost by oleks-rip · Pull Request #5488 · XRPLF/rippled · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Host function gas cost #5488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2025
Merged

Conversation

oleks-rip
Copy link
Collaborator

High Level Overview of Change

Add gas cost for host-functions

Context of Change

Now host function can have gas cost which will be passed to the VM as import and every time this function called gas limit will be updated accordingly.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

@oleks-rip oleks-rip requested a review from a team as a code owner June 11, 2025 15:40
@oleks-rip oleks-rip requested review from pwang200 and mvadari June 11, 2025 15:40
Copy link
codecov bot commented Jun 11, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.8%. Comparing base (8a33702) to head (ba2bfea).
Report is 1 commits behind head on ripple/smart-escrow.

Files with missing lines Patch % Lines
src/xrpld/app/misc/WamrVM.cpp 55.6% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           ripple/smart-escrow   #5488     +/-   ##
=====================================================
- Coverage                 78.8%   78.8%   -0.0%     
=====================================================
  Files                      826     826             
  Lines                    73106   73122     +16     
  Branches                  8528    8530      +2     
=====================================================
+ Hits                     57586   57595      +9     
- Misses                   15520   15527      +7     
Files with missing lines Coverage Δ
src/xrpld/app/misc/WamrVM.h 100.0% <ø> (ø)
src/xrpld/app/misc/WasmParamsHelper.h 100.0% <100.0%> (ø)
src/xrpld/app/misc/WamrVM.cpp 74.9% <55.6%> (+2.0%) ⬆️

... and 10 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@oleks-rip oleks-rip merged commit 51a9c0f into XRPLF:ripple/smart-escrow Jun 12, 2025
25 of 26 checks passed
oleks-rip added a commit to oleks-rip/rippled that referenced this pull request Jun 16, 2025
* Update Wamr to 2.3.1
* Add gas cost per host-function
* Fix windows build
* Fix wasm test
* Add no import test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0