Add support for DomainID in MPTokenIssuance transactions
#5509
+612
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DomainID in MPTokenIssuance transactions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5509 +/- ##
=======================================
Coverage 79.1% 79.1%
=======================================
Files 816 816
Lines 71622 71660 +38
Branches 8237 8235 -2
=======================================
+ Hits 56644 56684 +40
+ Misses 14978 14976 -2
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
300fe81 to
b486cdf
Compare
gregtatcam
reviewed
Jul 1, 2025
13ae4bd to
87282f2
Compare
gregtatcam
reviewed
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must ch
2CF7
ange the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Add support for
DomainIDto existing transactionsMPTokenIssuanceCreateandMPTokenIssuanceSetContext of Change
In #5224 we added
DomainIDas an access control mechanism forSingleAssetVault. The actual implementation of this feature lies inMPTokenandMPTokenIssuance, hence it makes sense to enable the use ofDomainIDalso inMPTokenIssuanceCreateandMPTokenIssuanceSet, following same rules as in Vault:MPTokenIssuanceCreateandMPTokenIssuanceSetcan only setDomainIDif flagMPTRequireAuthis setMPTokenIssuanceCreaterequires thatDomainIDbe a non-zero, uint256 numberMPTokenIssuanceSetallowsDomainIDto be zero (or empty) in which case it will removeDomainIDfrom theMPTokenIssuanceobjectThe change is amendment-gated by
SingleAssetVault.This is a non-breaking change because
SingleAssetVaultamendment isSupported::no, i.e. at this moment considered a work in progress, which cannot be enabled on the network.Type of Change
.gitignore, formatting, dropping support for older tooling)