fix: crash when trace-logging in tests #5529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5529 +/- ##
=========================================
- Coverage 79.1% 79.1% -0.0%
=========================================
Files 816 816
Lines 71605 71605
Branches 8237 8240 +3
=========================================
- Hits 56625 56619 -6
- Misses 14980 14986 +6 see 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Co-authored-by: Valentin Balaschenko <13349202+vlntb@users.noreply.github.com>
vlntb
approved these changes
Jul 2, 2025
Co-authored-by: Valentin Balaschenko <13349202+vlntb@users.noreply.github.com>
mvadari
added a commit
to mvadari/rippled
that referenced
this pull request
Jul 3, 2025
This PR fixes a crash in tests when the test `Env is run at trace/debug log level. This issue only affects tests, and only if logging at trace/debug level, so really only relevant during rippled development, and does not affect production servers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR fixes a crash in tests when the test `Env is run at trace/debug log level.
This issue only affects tests, and only if logging at trace/debug level, so really only relevant during rippled development, and does not affect production servers.
Note: I think the logs run a bit slower with this fix, due to the lock, but IMO that's not a big deal since this is only relevant for development
h/t @sublimator for the fix in the issue
Context of Change
Fixes #5388
Type of Change
API Impact
N/A
Test Plan
Worked locally.
Repro instructions are in the issue.