10000 Simplify host function boilerplate by mvadari · Pull Request #5534 · XRPLF/rippled · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Simplify host function boilerplate #5534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: ripple/smart-escrow
Choose a base branch
from
Open

Simplify host function boilerplate #5534

wants to merge 16 commits into from
+642 −691

Conversation

mvadari
Copy link
Collaborator
@mvadari mvadari commented Jul 3, 2025 •
edited
Loading

High Level Overview of Change

This PR simplifies the boilerplate for host functions a bit, to prevent typo bugs and make it easier to add additional host functions.

Context of Change

cleanup

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

Test Plan

CI passes.

@mvadari mvadari mentioned this pull request Jul 3, 2025
Open
13 tasks
@mvadari mvadari changed the title Simplify host function creation with the use of macros Simplify host function boilerplate Jul 3, 2025
@mvadari mvadari marked this pull request as ready for review July 7, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mvadari
0