Pause online delete if there any any gaps in recent ledger history #5531
+319
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e3975af to
b2c4c3d
Compare
b2c4c3d to
54f7f3c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5531 +/- ##
=======================================
Coverage 79.1% 79.1%
=======================================
Files 816 816
Lines 71622 71647 +25
Branches 8237 8229 -8
=======================================
+ Hits 56644 56673 +29
+ Misses 14978 14974 -4
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
- Add a test to exercise online delete ledger gap detection
This reverts commit e184db4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Adds another check to the online deletion process to prevent ledger gaps from persisting if the node goes out of sync.
Context of Change
Some nodes struggle to stay in sync when online delete is running due to the added I/O burden. This has proven difficult to avoid without upgrading hardware. If the process takes a particularly long time, which it can with large datasets, the node can end up with many gaps in the recent ledger history. Those gaps will not be filled until the node is idle enough for low-priority historical ledger requests to run.
Note that this is a trade-off. The online deletion may take longer to complete, but the node will stay more up-to-date.
Type of Change