8000 Fix compilation error with clang-20, cleanup by Bronek · Pull Request #5543 · XRPLF/rippled · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix compilation error with clang-20, cleanup #5543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 9, 2025
Merged

Fix compilation error with clang-20, cleanup #5543

merged 4 commits into from
Jul 9, 2025
+40 −7

Conversation

Bronek
Copy link
Collaborator
@Bronek Bronek commented Jul 9, 2025

High Level Overview of Change

Workaround for compilation error with clang-20, also remove clutter.

Type of Change

  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)

@Bronek Bronek added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Jul 9, 2025
@Bronek Bronek requested review from ximinez and bthomee July 9, 2025 11:06
@codecov Codecov
Copy link
codecov bot commented Jul 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.1%. Comparing base (a7eea95) to head (9fa3d65).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5543   +/-   ##
=======================================
  Coverage     79.1%   79.1%           
=======================================
  Files          816     816           
  Lines        71621   71622    +1     
  Branches      8256    8237   -19     
=======================================
+ Hits         56617   56644   +27     
+ Misses       15004   14978   -26
Files with missing lines Coverage Δ
include/xrpl/basics/Expected.h 100.0% <ø> (ø)
include/xrpl/beast/hash/hash_append.h 100.0% <ø> (ø)

... and 8 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ximinez
ximinez requested changes Jul 9, 2025
View reviewed changes
@Bronek Bronek force-pushed the Bronek/compilation_fixes branch from 541e9da to df84cfe Compare July 9, 2025 14:19
@Bronek Bronek requested a review from ximinez July 9, 2025 14:24
ximinez
ximinez approved these changes Jul 9, 2025
View reviewed changes
Copy link
Collaborator
@ximinez ximinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗

@Bronek Bronek added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Jul 9, 2025
@bthomee bthomee enabled auto-merge (squash) July 9, 2025 17:14
@bthomee bthomee merged commit f47e2f4 into develop Jul 9, 2025
27 checks passed
@bthomee bthomee deleted the Bronek/compilation_fixes branch July 9, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ximinez ximinez ximinez approved these changes

@bthomee bthomee bthomee approved these changes

Assignees
No one assigned
Labels
Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bronek @ximinez @bthomee
0