XRTK · StephenHodgson · Nov 22, 2020 · Nov 13, 2020 · Nov 14, 2020 · Nov 14, 2020
@@ -28,7 +28,21 @@ public WindowsDictationDataProvider(string name, uint priority, BaseMixedReality
 #if UNITY_STANDALONE_WIN || UNITY_WSA || UNITY_EDITOR_WIN
             if (dictationRecognizer == null)
             {
-                dictationRecognizer = new DictationRecognizer();
+                try
+                {
+                    dictationRecognizer = new DictationRecognizer();
+                }
+                catch (UnityException e)
+                {
+                    switch (e.Message)
+                    {
+                        case string message when message.Contains("Speech recognition is not supported on this machine."):
+                            Debug.LogWarning($"Skipping {nameof(WindowsDictationDataProvider)} registration.\n{e.Message}");
+                            break;
+                        default:
+                            throw;
+                    }
+                }
             }
 #endif // UNITY_STANDALONE_WIN || UNITY_WSA || UNITY_EDITOR_WIN
         }
@@ -40,7 +54,7 @@ public WindowsDictationDataProvider(string name, uint priority, BaseMixedReality
         /// <inheritdoc />
         public override void Enable()
         {
-            if (!Application.isPlaying) { return; }
+            if (!Application.isPlaying || dictationRecognizer == null) { return; }
 
             inputSource = MixedRealityToolkit.InputSystem.RequestNewGenericInputSource(Name);
             dictationResult = string.Empty;
@@ -56,7 +70,7 @@ public override void Update()
         {
             base.Update();
 
-            if (!Application.isPlaying) { return; }
+            if (!Application.isPlaying || dictationRecognizer == null) { return; }
 
             if (!isTransitioning && IsListening && !Microphone.IsRecording(deviceName) && dictationRecognizer.Status == SpeechSystemStatus.Running)
             {
@@ -76,7 +90,7 @@ public override async void Disable()
         {
             base.Disable();
 
-            if (!Application.isPlaying) { return; }
+            if (!Application.isPlaying || dictationRecognizer == null) { return; }
 
             if (!isTransitioning && IsListening) { await StopRecordingAsync(); }
 
@@ -90,7 +104,8 @@ protected override void OnDispose(bool finalizing)
         {
             if (finalizing)
             {
-                dictationRecognizer.Dispose();
+                dictationRecognizer?.Dispose();
+                dictationRecognizer = null;
             }
 
             base.OnDispose(finalizing);
@@ -149,7 +164,11 @@ public override async void StartRecording(GameObject listener = null, float init
         /// <inheritdoc />
         public override async Task StartRecordingAsync(GameObject listener = null, float initialSilenceTimeout = 5f, float autoSilenceTimeout = 20f, int recordingTime = 10, string micDeviceName = "")
         {
-            if (IsListening || isTransitioning || MixedRealityToolkit.InputSystem == null || !Application.isPlaying)
+            if (IsListening ||
+                isTransitioning ||
+                !Application.isPlaying ||
+                dictationRecognizer == null ||
+                MixedRealityToolkit.InputSystem == null)
             {
                 Debug.LogWarning("Unable to start recording");
                 return;
@@ -205,7 +224,10 @@ public override async void StopRecording()
         /// <inheritdoc />
         public override async Task<AudioClip> StopRecordingAsync()
         {
-            if (!IsListening || isTransitioning || !Application.isPlaying)
+            if (!IsListening ||
+                isTransitioning ||
+                !Application.isPlaying ||
+                dictationRecognizer == null)
             {
                 Debug.LogWarning("Unable to stop recording");
                 return null;

@@ -59,7 +59,21 @@ public WindowsSpeechDataProvider(string name, uint priority, BaseMixedRealityCon
 
            if (keywordRecognizer == null)
             {
-                keywordRecognizer = new KeywordRecognizer(newKeywords, (ConfidenceLevel)RecognitionConfidenceLevel);
+                try
+                {
+                    keywordRecognizer = new KeywordRecognizer(newKeywords, (ConfidenceLevel)RecognitionConfidenceLevel);
+                }
+                catch (UnityException e)
+                {
+                    switch (e.Message)
+                    {
+                        case string message when message.Contains("Speech recognition is not supported on this machine."):
+                            Debug.LogWarning($"Skipping {nameof(WindowsSpeechDataProvider)} registration.\n{e.Message}");
+                            break;
+                        default:
+                            throw;
+                    }
+                }
             }
 #endif // UNITY_STANDALONE_WIN || UNITY_WSA || UNITY_EDITOR_WIN
         }
@@ -73,7 +87,7 @@ public override void Enable()
         {
             base.Enable();
 
-            if (!Application.isPlaying || Commands.Length == 0) { return; }
+            if (!Application.isPlaying || Commands.Length == 0 || keywordRecognizer == null) { return; }
 
             InputSource = MixedRealityToolkit.InputSystem?.RequestNewGenericInputSource("Windows Speech Input Source");
 
@@ -90,7 +104,7 @@ public override void Update()
         {
             base.Update();
 
-            if (!keywordRecognizer.IsRunning) { return; }
+            if (keywordRecognizer == null || !keywordRecognizer.IsRunning) { return; }
 
             for (int i = 0; i < Commands.Length; i++)
             {
@@ -106,7 +120,7 @@ public override void Disable()
         {
             base.Disable();
 
-            if (!Application.isPlaying || Commands.Length == 0) { return; }
+            if (!Application.isPlaying || Commands.Length == 0 || keywordRecognizer == null) { return; }
 
             StopRecognition();
 
@@ -117,7 +131,8 @@ protected override void OnDispose(bool finalizing)
         {
             if (finalizing)
             {
-                keywordRecognizer.Dispose();
+                keywordRecognizer?.Dispose();
+                keywordRecognizer = null;
             }
 
             base.OnDispose(finalizing);
@@ -140,7 +155,7 @@ protected override void OnDispose(bool finalizing)
         private static KeywordRecognizer keywordRecognizer;
 
         /// <inheritdoc />
-        public override bool IsRecognitionActive => keywordRecognizer.IsRunning;
+        public override bool IsRecognitionActive => keywordRecognizer != null && keywordRecognizer.IsRunning;
 
         /// <summary>
         /// The <see cref="RecognitionConfidenceLevel"/> that the <see cref="KeywordRecognizer"/> is using.
@@ -150,7 +165,7 @@ protected override void OnDispose(bool finalizing)
         /// <inheritdoc />
         public override void StartRecognition()
         {
-            if (!keywordRecognizer.IsRunning)
+            if (keywordRecognizer != null && !keywordRecognizer.IsRunning)
             {
                 keywordRecognizer.Start();
             }
@@ -159,7 +174,7 @@ public override void StartRecognition()
         /// <inheritdoc />
         public override void StopRecognition()
         {
-            if (keywordRecognizer.IsRunning)
+            if (keywordRecognizer != null && keywordRecognizer.IsRunning)
             {
                 keywordRecognizer.Stop();
             }

@@ -799,7 +799,7 @@ PlayerSettings:
     m_PortalFolderPath: 
   luminCert:
     m_CertPath: 
-    m_SignPackage: 1
+    m_SignPackage: 0
   luminIsChannelApp: 0
   luminVersion:
     m_VersionCode: 1

@@ -1,3 +1,12 @@
+# XRTK Azure Pipelines build configuration
+
+resources:
+  repositories:
+    - repository: pipeline_repo
+      type: github
+      name: XRTK/AzurePipelines
+      endpoint: XRTK
+
 variables:
   project.name: 'XRTK-Core'
   project.upmSha: ''
@@ -51,5 +60,17 @@ trigger:
       - XRTK-Core/Packages/com.xrtk.core/.github/*
 
 extends:
-  template: azure_pipelines/common.yml
-
+  template: common.yml@pipeline_repo
+  parameters:
+    # Unity -buildTarget command line args https://docs.unity3d.com/Manual/CommandLineArguments.html
+    # StandaloneWindows64, WSAPlayer, StandaloneOSX, iOS, StandaloneLinux64, Android, WebGL, Lumin
+    # TODO: Only use XRTK defined platform targets for build
+    targets:
+      - StandaloneWindows64
+      - WSAPlayer
+      - StandaloneOSX
+      - iOS
+      - StandaloneLinux64
+      - Android
+      - Lumin
+      - WebGL