8000 Add Xcode 8.3beta1 compatibility by mkalinowski · Pull Request #1040 · XVimProject/XVim · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Xcode 8.3beta1 compatibility #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add Xcode 8.3beta1 compatibility #1040

wants to merge 1 commit into from

Conversation

mkalinowski
Copy link
@mkalinowski mkalinowski commented Jan 25, 2017 •
edited
Loading

Problem:
Compilation of the lastest master on Xcode 8.3beta1 fails with:

    /Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -arch x86_64 -bundle -isysroot /Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -L/Users/mikolaj/Projects/XVim/build/Release -L/Applications/Xcode-beta.app/Contents/Developer/../PlugIns/IDESourceEditor.ideplugin/Contents/MacOS -F/Users/mikolaj/Projects/XVim/build/Release -F/Applications/Xcode-beta.app/Contents/Developer/../Frameworks -F/Applications/Xcode-beta.app/Contents/Developer/../PlugIns -F/Applications/Xcode-beta.app/Contents/Developer/../SharedFrameworks -filelist /Users/mikolaj/Projects/XVim/build/XVim.build/Release/XVim.build/Objects-normal/x86_64/XVim.LinkFileList -mmacosx-version-min=10.7 -Xlinker
-object_path_lto -Xlinker /Users/mikolaj/Projects/XVim/build/XVim.build/Release/XVim.build/Objects-normal/x86_64/XVim_lto.o -fobjc-arc -fobjc-link-runtime
-framework AppKit -framework Cocoa -framework IDEFoundation -framework IDEKit -framework DVTFoundation -framework DVTKit /Applications/Xcode-beta.app/Contents/PlugIns/IDELanguageSupportUI.ideplugin/Contents/MacOS/IDELanguageSupportUI /Applications/Xcode-beta.app/Contents/PlugIns/IDESourceEditor.ideplugin/Contents/MacOS/IDESourceEditor -Xlinker -dependency_info -Xlinker /Users/mikolaj/Projects/XVim/build/XVim.build/Release/XVim.build/Objects-normal/x86_64/XVim_dependency_info.dat -o /Users/mikolaj/Projects/XVim/build/Release/XVim.xcplugin/Contents/MacOS/XVim
Undefined symbols for architecture x86_64:
  "_OBJC_CLASS_$_IDEPlaygroundEditor", referenced from:
      objc-class-ref in XVimHookManager.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

** BUILD FAILED **

Root cause:
The problem happens, because IDEPlaygroundEditor is not defined anymore in /Applications/Xcode.app/Contents/PlugIns/IDELanguageSupportUI.ideplugin/Contents/MacOS/IDELanguageSupportUI

Solution:
Remove IDEPlaygroundEditor+XVim extension and rely on IDESourceCodeEdtior+XVim

Testing:
XVim still works in Playgrounds in Xcode8.3beta1

@fe9lix
Copy link
fe9lix commented Jan 28, 2017

Hi! Still couldn't compile XVim with the changes of your PR. I had to go into the project and remove the import from XVimHookManager.m and also remove IDEPlaygroundEditor+XVim.m from Compile Sources (Target -> Build Phases...).

@DarthMike
Copy link

👍 After @fe9lix's changes works fine for me.

@tmm1
Copy link
tmm1 commented Mar 27, 2017

@fe9lix Can you open a PR with your fix?

@keith
Copy link
Contributor
keith commented Mar 27, 2017

Here's a new PR that makes all these changes #1055

@JugglerShu JugglerShu closed this Apr 11, 2017
@darylsew
Copy link
darylsew commented Apr 16, 2017 •
edited
Loading

Hm, I'm getting this error in XCode 8.3.1 (not Beta), and it looks very similar. Any thoughts?

Undefined symbols for architecture x86_64:
  "_OBJC_CLASS_$_IDEPlaygroundEditor", referenced from:
      anon in IDEPlaygroundEditor+XVim.o
      l_OBJC_$_CATEGORY_IDEPlaygroundEditor_$_XVim in IDEPlaygroundEditor+XVim.o
      objc-class-ref in XVimHookManager.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

@darylsew
Copy link

This was on master (revision 4ac2725), it actually builds fine on develop and everything seems to work, so you can ignore my earlier comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mkalinowski @fe9lix @DarthMike @tmm1 @keith @darylsew @JugglerShu
0