Share Underlying articles #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nly shared articles have access_token, set only if shared was enabled
09d8b66 to
91a6ff3
Compare
…ow articles to be searched for fixing tree panel to left
…set to share underlying articles, they're now shared too.
11f2b00 to
4ea672f
Compare
… with token and it is set to share underlying articles, they're now shared too.
…ge_share_underlying_with_token: added file descriptor
|
@Yenthe666 When you get bored or want to blame somebody, maybe you can check this (and rest) PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two apps:
knowledge_share_underlying: to share all children from an ancestor (tree down)knowledge_share_underlying_with_token: to supportknowledge_share_underlying+knowledge_share_with_token.It works mainly as the following. If an article is shared and set share underlying articles, then all underlying articles are shared too. This allow the possibility of of sharing workspaces instead of sharing one article by one.
It also include some fixings for main app
knowledge_share_with_token:access_token, it was making all articles to have an access token even if they're not shared, increasing DB usage.access_token