8000 Python wheels do not contain the LICENSE.txt file · Issue #7604 · Z3Prover/z3 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Python wheels do not contain the LICENSE.txt file #7604

New issue

Have a question about this project? Sign 8000 up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
markdryan opened this issue Apr 3, 2025 · 1 comment · Fixed by #7614
Closed

Python wheels do not contain the LICENSE.txt file #7604

markdryan opened this issue Apr 3, 2025 · 1 comment · Fixed by #7614
Labels
help wanted

Comments

@markdryan
Copy link
Contributor

To reproduce, simply download a wheel, e.g., z3_solver-4.14.1.0-py3-none-manylinux_2_17_x86_64.manylinux2014_x86_64.whl, from https://pypi.org/project/z3-solver/#files and unzip it. There's no license file.

The license file is however present in the corresponding source distribution, in the core folder.

The license says "The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software." so it really should be included in the wheels.
@NikolajBjorner
Copy link
Contributor

If you have bandwidth to add it to the process that uses setup.py to build the wheels it is good.
There are already some references to LICENSE.txt in setup.py but these don't result in including them.

markdryan added a commit to markdryan/z3 that referenced this issue Apr 7, 2025
@markdryan
include LICENSE.txt in wheels
93a08a5 
Update setup.py so that we copy LICENSE.TXT to src/api/python before
creating the sdist.  Any wheels built from this sdist will now
contain the LICENSE.txt file.

Fixes Z3Prover#7604
@markdryan markdryan mentioned this issue Apr 7, 2025
Merged
NikolajBjorner pushed a commit that referenced this issue Apr 7, 2025
@markdryan
include LICENSE.txt in wheels (#7614)
14e2aad 
Update setup.py so that we copy LICENSE.TXT to src/api/python before
creating the sdist.  Any wheels built from this sdist will now
contain the LICENSE.txt file.

Fixes #7604
arbipher pushed a commit to arbipher/z3 that referenced this issue Apr 17, 2025
@markdryan @arbipher
include LICENSE.txt in wheels (Z3Prover#7614)
ce845ec 
Update setup.py so that we copy LICENSE.TXT to src/api/python before
creating the sdist.  Any wheels built from this sdist will now
contain the LICENSE.txt file.

Fixes Z3Prover#7604
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

include LICENSE.txt in wheels markdryan/z3
2 participants
@markdryan @NikolajBjorner
0