feat(UX-1454): Empty State Widget #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new ZetaEmptyState component with its story, tests, and example, adds a utility for formatting camelCase labels, and updates all text styles to include explicit letterSpacing: 0.
- Add
sentencerhelper to split camelCase strings into human-readable labels. - Implement
ZetaEmptyStatewidget, register it in widgetbook, export it, and cover it with tests and an example. - Update typography definitions to set
letterSpacing: 0for all text styles.
Reviewed Changes
Copilot reviewed 9 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| widgetbook/lib/src/utils/utils.dart | Add sentencer function for camelCase splitting |
| widgetbook/lib/src/components/empty_state.widgetbook.dart | Register the Empty State use case in widgetbook |
| widgetbook/lib/main.directories.g.dart | Update generated structure to include EmptyState |
| packages/zeta_flutter_theme/lib/src/typography.dart | Set letterSpacing: 0 on all text style definitions |
| packages/zeta_flutter/test/src/components/empty_state/empty_state_test.dart | Add golden, accessibility, content, dimensions, styling, and ordering tests for ZetaEmptyState |
| packages/zeta_flutter/lib/zeta_components.dart | Export the new empty_state.dart component |
| packages/zeta_flutter/lib/src/components/empty_state/empty_state.dart | Implement the ZetaEmptyState widget |
| example/lib/pages/components/empty_state_example.dart | Provide a live example of the Empty State component |
| example/lib/home.dart | Register EmptyStateExample in the example app |
Comments suppressed due to low confidence (3)
widgetbook/lib/src/utils/utils.dart:15
- [nitpick] The function name 'sentencer' is ambiguous—consider renaming it to something like 'toSentence' or 'splitCamelCase' for clarity.
String sentencer(String? value) {
widgetbook/lib/src/utils/utils.dart:15
- Consider adding unit tests for 'sentencer' to verify correct behavior on various camelCase and edge-case inputs.
String sentencer(String? value) {
packages/zeta_flutter/test/src/components/empty_state/empty_state_test.dart:123
- The 'Interaction Tests' group is empty—either implement relevant interactions or remove the unused group.
group('Interaction Tests', () {});
packages/zeta_flutter/lib/src/components/empty_state/empty_state.dart
Outdated
8000
Show resolved
Hide resolved
packages/zeta_flutter/lib/src/components/empty_state/empty_state.dart
Outdated
Show resolved
Hide resolved
|
Visit the preview URL for this PR (updated for commit 6a565a6): https://zeta-flutter-main--pr-361-ux-1454-is90zmsu.web.app (expires Wed, 09 Jul 2025 13:48:38 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 5ca681de0a0ad9185b252304c113355d5ee04ca6 |
PR Checks complete
Created with Flutter code quality action |
DE7924
approved these changes
Jul 3, 2025
DE7924
approved these changes
Jul 3, 2025
This was referenced Jul 3, 2025
thelukewalton
added a commit
that referenced
this pull request
Jul 3, 2025
🤖 I have created a release *beep* *boop* --- ## [1.2.0](zeta_flutter_theme-v1.1.2...zeta_flutter_theme-v1.2.0) (2025-07-03) ### ✨ New Features * **UX-1454:** Empty State Widget ([#361](#361)) ([b167ee6](b167ee6)) ### 🪲 Bug Fixes * Update text themes with line height 0 ([b167ee6](b167ee6)) * **UX-1460:** Update badges to latest designs ([#355](#355)) ([c0c61fc](c0c61fc)) ### ⛓️ Dependencies * **automated:** Update theme tokens ([#354](#354)) ([6d3585e](6d3585e)) ### 🧪 Tests * Add more thorough accessibility and styling tests ([c0c61fc](c0c61fc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
thelukewalton
added a commit
that referenced
this pull request
Jul 4, 2025
🤖 I have created a release *beep* *boop* --- ## [1.2.0](zeta_flutter-v1.1.3...zeta_flutter-v1.2.0) (2025-07-04) ### ✨ New Features * **UX-1454:** Empty State Widget ([#361](#361)) ([b167ee6](b167ee6)) ### 🪲 Bug Fixes * Update text themes with line height 0 ([b167ee6](b167ee6)) * **UX-1460:** Update badges to latest designs ([#355](#355)) ([c0c61fc](c0c61fc)) ### 🧪 Tests * Add more thorough accessibility and styling tests ([c0c61fc](c0c61fc)) ### 🧹 Miscellaneous Chores * ** zeta_flutter_theme:** release 1.2.0 ([#360](#360)) ([8cea819](8cea819)) * ** zeta_flutter_utils:** release 1.1.2 ([#359](#359)) ([4cfd329](4cfd329)) * ** zeta_icons:** release 1.1.3 ([#357](#357)) ([39aa872](39aa872)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Update text themes with line height 0
test: Add tests for empty state widget