8000 feat: Show more information in the Pomodoro timer. by Shafiia · Pull Request #5750 · Zettlr/Zettlr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Show more information in the Pomodoro timer. #5750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and pri 8000 vacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Shafiia
Copy link
@Shafiia Shafiia commented May 2, 2025

Description

Closes #5668
This PR adds a visual indicator of the user's progress through the cycle in the pomodoro timer popover. It also displays the number of work sessions a user has completed.

Changes

In the PopoverPomodoro.vue file, I modified the 'v-if="isRunning"' block to include a visual pomodoro cycle tracker using coloured dots for each phase. The coloured dots remain muted until completed. I've also added a line showing the total number of work sessions.
In the App.vue file, I added a new 'totalTasks' field to the 'pomodoro' object to track cumulative work sessions. I've also modified the 'pomodoroTick()' to increment 'totalTasks' and reset 'counter' after a full 8-phase Pomodoro cycle.

Tested on: Ubuntu 24.04.1 LTS (noble) via WSL2 on Windows 11
Tested and working successfully.

Copy link
boring-cyborg bot commented May 2, 2025

Thank you for opening your first PR! 🎉 We would like to thank you already for your contribution. If everything checks out, we'll make sure to review the PR as soon as possible and give feedback. Please note a few things:

  • For every PR, the automated pipeline will run the linter and unit tests on
    your code. Should these fail, we will not merge your PR.
  • Activate your notifications and check your inbox regularly to respond to our
    reviews and/or comments.

We are glad for every improvement that makes its way into the app, so we look forward to collaborating on merging this PR.

@Shafiia
Copy link
Author
Shafiia commented May 10, 2025

Hello, just following up on this PR. Please let me know if anything needs to be updated on my end. Thanks!

@nathanlesage
Copy link
Member

I can't do much right now, I have a full week. But one question I had was, why did you implement this dot solution, given that, in the issue itself, we also were discussing a ring based solution (which, at least to my knowledge, is the more … "typical" implementation)?

@Shafiia
Copy link
Author
Shafiia commented May 13, 2025

I understand. Actually, I implemented the initial (very first) proposed solution and used coloured dots instead of the tomato icons to prevent confusion. Now, I'm working on the circular ring-based solution and will open a new PR once it's ready. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show more information in the pomodoro timer.
2 participants
0