Fixes minor bootstrap 3 issues with login form. #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the floating checkbox over the label per the basic example provided in Bootstrap 3's documentation. The default bootstrap CSS applies a negative left margin to the checkbox, so the box should come before the label text. Also, the containing div should be classed as a "checkbox" not "form-control." Also added the 'role="form"' to the form declaration and moved the "forgot password" link to a paragraph classed "help-block" below the password entry for consistency with Bootstrap 3 documentation.
|
Thanks for this! |
Zizaco
added a commit
that referenced
this pull request
Oct 25, 2014
Fixes minor bootstrap 3 issues with login form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the floating checkbox over the "remember me" label per the basic example provided in Bootstrap 3's documentation.
The default bootstrap CSS applies a negative left margin to the checkbox, so the box should come before the label text. Also, the containing div should be classed as a "checkbox" not "form-control." Also added the 'role="form"' to the form declaration and moved the "forgot password" link to a paragraph classed "help-block" below the password entry for consistency with Bootstrap 3 documentation.