This repository was archived by the owner on Jun 19, 2024. It is now read-only.
Add reason string to InvalidTxData error. #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rllola
approved these changes
Feb 15, 2024
|
Yes that's a good improvement and should help a lot with debugging. Thank you for your contribution @joel-u410 |
|
Yes i have merged it. If you can rebase that would be perfect. |
353bd44 to
357fbb6
Compare
HadesGuard
pushed a commit
to HadesGuard/namadexer
that referenced
this pull request
Feb 23, 2024
There are several different places where `Error::InvalidTxData` can be produced; this adds a `String` value to it so that every place that results in this error can also provide a helpful explanation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several different places where
Error::InvalidTxDatacan be produced; this adds aStringvalue to it so that every place that results in this error can also provide a helpful explanation.