8000 Added option to clear search input on show by bevacqua · Pull Request #43 · muan/mojibar · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jun 22, 2022. It is now read-only.

Added option to clear search input on show #43

Merged
merged 4 commits into from
Feb 9, 2016
Merged

Conversation

bevacqua
Copy link
Contributor
@bevacqua bevacqua commented Feb 8, 2016

Hey, I use mojibar a ton and love it! 🚀

I added this option because I typically want different emoji and the fact that the search input is never cleared is annoying for my use case, as I typically would:

  • open via shortcut
  • type search query
  • pick the emoji with keyboard
  • paste the emoji on an input
  • open via shortcut again
  • try to type search query, but pre-existing query gets in the way
  • type search query anyways so that the input is focused
  • clear input
  • type search query
  • ...

This PR eliminates the italicized steps by adding a setting to forget the current input on show

@muan
Copy link
Owner
muan commented Feb 9, 2016

👍 Nice! Thank you.

I've been thinking about this as well. I'd be inclined to set this to be the default behaviour, and probably call it something like "Clear input oncopy/open" instead of "Remember input" so it'd be closer to the actual behaviour.

@timmfin
Copy link
timmfin commented Feb 9, 2016

I'd second that clearing the input (after a emoji has been selected) should be the default.

I'd even say that there shouldn't be an option, I'd argue that the case where you want to preserve input (searching for similar emoji) is rare and pretty well handled by copy and paste.

And thanks! These changes will make using mojibar much better 😸

@bevacqua
Copy link
Contributor Author
bevacqua commented Feb 9, 2016

@muan Let me know of any changes you want me to make and I'll put them together

@muan
Copy link
Owner
muan commented Feb 9, 2016

Yeahhhh, thanks for chiming in @timmfin. @bevacqua I think we can drop the preference and just make it so it clears. I'd prefer to avoid another checkbox if possible, we can revisit this in the future if things change. ✌️

I think also the input clearing can be put into the copy action before aborting the app, what do you think?

@bevacqua
Copy link
Contributor Author
bevacqua commented Feb 9, 2016

Okay.

  • Clears input on copy, so that input stays there across show/hide if no emoji was picked
  • Focuses input on show so that you don't have to click or tab
  • Left in the code that allows you to add boolean settings in the future, but let me know if you want that removed

@muan
Copy link
Owner
muan commented Feb 9, 2016

Left in the code that allows you to add boolean settings in the future, but let me know if you want that removed

I'd prefer to have them removed in one commit, and potentially revert when things change. Thanks for putting in all the work for it though! I'd definitely like to use it one day. ⭐

@bevacqua
Copy link
Contributor Author
bevacqua commented Feb 9, 2016

Done

muan added a commit that referenced this pull request Feb 9, 2016
Added option to clear search input on show
@muan muan merged commit 5dff4e3 into muan:master Feb 9, 2016
@muan
Copy link
Owner
muan commented Feb 9, 2016

🌟 Thank you so much.

@muan
Copy link
Owner
muan commented Feb 10, 2016

Release 2.2.1 is out ✨

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0