-
-
Notifications
You must be signed in to change notification settings - Fork 123
Added option to clear search input on show #43
Conversation
👍 Nice! Thank you. I've been thinking about this as well. I'd be inclined to set this to be the default behaviour, and probably call it something like "Clear input oncopy/open" instead of "Remember input" so it'd be closer to the actual behaviour. |
I'd second that clearing the input (after a emoji has been selected) should be the default. I'd even say that there shouldn't be an option, I'd argue that the case where you want to preserve input (searching for similar emoji) is rare and pretty well handled by copy and paste. And thanks! These changes will make using mojibar much better 😸 |
@muan Let me know of any changes you want me to make and I'll put them together |
Yeahhhh, thanks for chiming in @timmfin. @bevacqua I think we can drop the preference and just make it so it clears. I'd prefer to avoid another checkbox if possible, we can revisit this in the future if things change. ✌️ I think also the input clearing can be put into the copy action before aborting the app, what do you think? |
Okay.
|
I'd prefer to have them removed in one commit, and potentially revert when things change. Thanks for putting in all the work for it though! I'd definitely like to use it one day. ⭐ |
Done |
Added option to clear search input on show
🌟 Thank you so much. |
Release 2.2.1 is out ✨ |
Hey, I use
mojibar
a ton and love it! 🚀I added this option because I typically want different emoji and the fact that the search input is never cleared is annoying for my use case, as I typically would:
This PR eliminates the italicized steps by adding a setting to forget the current input on
show