FIX(client, ui): ACLEditor not growing 8000 evenly #4455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ACLEditor's Groups tab has 3 separate columns for dealing with members. These columns wouldn't grow equally though: The 2 leftmost columns basically didn't grow at all while the rightmost grew to fill the available space. This is a problem though since the 2 leftmost columns have a ComboBox in them and if the user wants to make those bigger, then (s)he expects this to be possible by increasing the window's size. This was not the case though and the ComboBoxes stayed at their initial size. This commit makes sure that all columns now grow equally and thus allowing the user to increase the ComboBoxe's size by increasing the window's size. Fixes mumble-voip#4453
Krzmbrzl
added a commit
that referenced
this pull request
Sep 4, 2020
…owing evenly" Backport of #4455
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ACLEditor's Groups tab has 3 separate columns for dealing with
members. These columns wouldn't grow equally though: The 2 leftmost
columns basically didn't grow at all while the rightmost grew to fill
the available space.
This is a problem though since the 2 leftmost columns have a ComboBox in
them and if the user wants to make those bigger, then (s)he expects this
to be possible by increasing the window's size. This was not the case
though and the ComboBoxes stayed at their initial size.
This commit makes sure that all columns now grow equally and thus
allowing the user to increase the ComboBoxe's size by increasing the
window's size.
Fixes #4453