BUILD(macOS): Only include ".dylib" files in bundle's "Plugins" directory #4649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4f3d7cc to
fe2bbfb
Compare
…tory In addition to the plugins, the "plugins" folder in the build directory also contains temporary build files. As the script was copying the entire tree, those files made their way into the bundle. This commit fixes the issue by explicitly copying only files that end with ".dylib".
fe2bbfb to
f19a645
Compare
davidebeatrici
commented
Dec 24, 2020
| shutil.copytree(os.path.join(options.binary_dir, 'plugins'), dst, symlinks=True) | ||
| if not os.path.exists(dst): | ||
| os.makedirs(dst) | ||
| for plugin in glob.glob('plugins/*.dylib'): |
There was a problem hiding this comment.
This should've been:
for plugin in glob.glob(os.path.join(options.binary_dir, 'plugins/*.dylib')):CI doesn't show any issues because we use the build folder as working directory.
There was a problem hiding this comment.
The script could definitely benefit from a revamp/rewrite.
@Krzmbrzl What do you think?
There was a problem hiding this comment.
Probably true. But personally I don't think I have the time nor the motivation to do it myself 🤷
There was a problem hiding this comment.
No worries, as long as it works we can keep it like that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the plugins, the
pluginsfolder in the build directory also contains temporary build files.As the script was copying the entire tree, those files made their way into the bundle.
This commit fixes the issue by explicitly copying only files that end with
.dylib.