Replace an NBSP (ASCII 160) with a space (ASCII 32) in sections.yml #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace a NBSP (ASCII 160) with a space (ASCII 32)
jgonggrijp
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Thank you for bringing this to our attention and for contributing a fix.
I reviewed the change with two other programs to triple-check that this is only replacing one NBSP with a regular space. I see no reason why that particular space would need to be a NBSP, so I agree this change is for the better.
If you don't mind, please update the JSON as well. Otherwise, just let me know and I will do it.
|
I ran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue parsing the json version of this file on a linux/amd64 test runner (but not my local arm64 Mac). Took me a while to find it, but I believe it's because of this NBSP (ASCII 160) character.
Most parsers would probably handle this better than the one I made 😁 , but I also thought there wouldn't be any harm in swapping it out for an SPACE (ASCII 32)