8000 Enforce strict type checks in the example apps by mwouts · Pull Request #401 · mwouts/itables · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Enforce strict type checks in the example apps #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2025
Merged

Enforce strict type checks in the example apps #401

merged 1 commit into from
Jun 6, 2025

Conversation

mwouts
Copy link
Owner
@mwouts mwouts commented Jun 1, 2025

This is another step in the direction of #390

@mwouts mwouts added this to the 2.4.1 milestone Jun 1, 2025
@github-actions GitHub Actions
Copy link
github-actions bot commented Jun 1, 2025

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab.

Also, the version of ITables developed in this PR can be installed with pip:

pip install git+https://github.com/mwouts/itables.git@strict_type_checking_in_apps

(this requires nodejs, see more at Developing ITables)

@codecov-commenter
Copy link
codecov-commenter commented Jun 1, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 89.62%. Comparing base (8fa250a) to head (0d02086).

Files with missing lines Patch % Lines
apps/streamlit/itables_app.py 73.68% 5 Missing ⚠️
apps/shiny/itable_widget/app-core.py 50.00% 2 Missing ⚠️
apps/shiny/itables_DT/app-core.py 50.00% 2 Missing ⚠️
src/itables_for_dash/properties.py 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #401      +/-   ##
==========================================
- Coverage   89.63%   89.62%   -0.01%     
==========================================
  Files          44       44              
  Lines        1852     1851       -1     
==========================================
- Hits         1660     1659       -1     
  Misses        192      192

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mwouts mwouts force-pushed the strict_type_checking_in_apps branch 3 times, most recently from 1c43011 to 6153f4f Compare June 6, 2025 20:40
@mwouts mwouts force-pushed the strict_type_checking_in_apps branch from 6153f4f to 0d02086 Compare June 6, 2025 20:42
@mwouts mwouts merged commit 1a65c2e into main Jun 6, 2025
15 checks passed
@mwouts mwouts deleted the strict_type_checking_in_apps branch June 6, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@mwouts @codecov-commenter
0