Latest patch bumped MSRV for logos-derive #449
Comments
|
Indeed, we bumped the MSRV without documenting it, as we don't have any specific policy for this. I usually don't mind bumping MSRV if that enables new features, but we could at least document that. |
|
Yes, well protox defines MSRV which is what we use but logos broke that MSRV for protox, so now protox also doesn't have proper MSRV. |
You mean because of us, or because you never had a proper MSRV?
I am not sure to understand the second part of your sentence. To me, it makes sense that bumping dependencies might require bumping your project's MSRV, no? |
|
MSRV bump is technically a breaking change, so it should probably warrant a 0.15 release I reckon. |
I'm saying that we don't use logos directly but it broke our build even though protox has strict Msrv defined.
Not with path versions. @maciejhirsz yes, I suppose a bump in the minor version would solve the issues for the future. |
I agree that it can be considered a breaking change (e.g., dropping support for a Python version in is usually considered a breaking changes), but Rust is also very different as it releases new versions more frequently and update are very easy: all to say that it might be better to define a clear versioning policy.
Yeah, I forgot that Rust crates usually specify dependency versions as
It's true, this is just that I am more used to the standard semantic versioning, where bumping I will yank |
Release 0.14.3 as 0.15, as it bumped the MSRV, see #449.
Release 0.14.3 as 0.15, as it bumped the MSRV, see #449.
Given that we used
protoxcrate which has set logos to 0.14,since the latest update it now requires MSRV of 1.74.What is your policy for MSRV bumping?
I see that the latest MSRV in the CHANGELOG was mentioned but not the latest one (for 0.14.3)
The text was updated successfully, but these errors were encountered: