add optional disablement of symlink validation #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, landing on green |
|
3.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Some tarballs have symlinks that are valid after extraction but not from the context of the extraction working directory, specifically, a symlink with an absolute path that is valid once you enter the chroot. An example of tool that creates tarballs like this is lxc distro builder: https://github.com/lxc/distrobuilder, the tar cli program is also able to extract these and prior versions of this module were able to extract these.
This adds the ability to disable symlink validation with a new parameter
validateSymlinkswhich defaults to true if not provided.