8000 Merge any set of models by Floppy · Pull Request #4456 · manyfold3d/manyfold · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Merge any set of models #4456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jul 3, 2025
Merged

Merge any set of models #4456

merged 18 commits into from
Jul 3, 2025

Conversation

Floppy
Copy link
Collaborator
@Floppy Floppy commented Jul 2, 2025

This extends our current merging system (which only handles children and parents) to any combination of models, even across libraries.

Resolves #2737

@Floppy Floppy added the feature User-facing features and product enhancements label Jul 2, 2025
@Floppy Floppy force-pushed the combine-any-models branch from a3c90cb to c1d1255 Compare July 2, 2025 17:01
@codacy-production Codacy Production
Copy link
codacy-production bot commented Jul 2, 2025 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.16% (target: -1.00%) ✅ 91.57%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (230d235) 4658 3908 83.90%
Head commit (f6becad) 4710 (+52) 3959 (+51) 84.06% (+0.16%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4456) 83 76 91.57%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@Floppy Floppy force-pushed the combine-any-models branch from fa217ca to 4d04988 Compare July 3, 2025 11:33
@Floppy Floppy force-pushed the combine-any-models branch from 4d04988 to 21c2a3c Compare July 3, 2025 11:58
@Floppy Floppy force-pushed the combine-any-models branch from 21c2a3c to f6becad Compare July 3, 2025 12:15
@Floppy Floppy marked this pull request as ready for review July 3, 2025 12:19
@Floppy Floppy enabled auto-merge July 3, 2025 12:19
@Floppy Floppy disabled auto-merge July 3, 2025 12:31
@Floppy Floppy merged commit dc26a98 into main Jul 3, 2025
13 checks passed
@Floppy Floppy deleted the combine-any-models branch July 3, 2025 12:31
@github-project-automation github-project-automation bot moved this from Maybe to Done in Manyfold Roadmap Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature User-facing features and product enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge any set of models
1 participant
@Floppy
0