8000 Slightly improve 404 and 500 error pages by matthewbadeau · Pull Request #4452 · manyfold3d/manyfold · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Slightly improve 404 and 500 error pages #4452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

Slightly improve 404 and 500 error pages #4452

merged 1 commit into from
Jul 1, 2025
+4 −0

Conversation

matthewbadeau
Copy link
Collaborator

… main page

Checklist

🚨 Please review the guidelines for contributing to this repository. 🚨

  • Make sure you are making a pull request against our main branch (left side)
  • Check that that your branch is up to date with our main.
  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your main!
  • Check that the tests and code linter both pass.
  • If you're a new contributor, please sign our contributor license agreement.

Warnings

  • This PR will change existing database contents.
  • This PR introduces a breaking change to existing installations.

Summary

This makes a tiny modification to the 404 and 500 pages to add a link to the main page

Linked issues

This doesn't quite fix the problem mentioned in #4451 but it does give a slightly experience.

Description of changes

  • Adds a "Return to main page" link on the 404 and 500 error pages

8000
@matthewbadeau matthewbadeau mentioned this pull request Jul 1, 2025
Open
@codacy-production Codacy Production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ -0.03% (target: -1.00%) ✅ ∅
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f471963) 4652 3904 83.92%
Head commit (442071c) 4655 (+3) 3905 (+1) 83.89% (-0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4452) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Floppy
Floppy approved these changes Jul 1, 2025
View reviewed changes
Copy link
Collaborator
@Floppy Floppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work for sites that aren't at the root, but with static pages, it's the best we can do for now.

@Floppy Floppy merged commit 6e3d539 into main Jul 1, 2025
14 checks passed
@Floppy Floppy deleted the feature/slightly_improved_404and500_page branch July 1, 2025 13:59
@github-project-automation github-project-automation bot moved this from Maybe to Done in Manyfold Roadmap Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Floppy Floppy Floppy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewbadeau @Floppy
0