Refactor: Split Code into Separate Files for Better Organization and added Share Functionality #8
Conversation
…tons and QR code modal, and link external script for functionality
|
@sands21 is attempting to deploy a commit to the Marko D's projects Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for denicmarko ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@sands21 I like. The share buttons are a bit off on the mobile. Can you take a look, please? |
…veness with media queries for share buttons, container, and modal
|
Hi yeah I looked into it and fixed it. It should be good now. |
There was a problem hiding this comment.
@sands21 I checked this more in detail. I don't like the share functionality, I think it's shifting attention from the links. I would take the refactor, though. Feel free to reopen or create a new PR!
I removed the share buttons and the qr code entirely while keeping the refactor. Please look into it |
There was a problem hiding this comment.
@sands21 Nicely done! There's only the QR code script left behind. Can you please remove it?
Removed the unused code. It should be clean now. Sorry for the blunder before |
Changes Made
This PR improves the codebase structure by separating the monolithic index.html file into three distinct files:
index.html- Core HTML structurestyles.css- All styling rules and theme variablesscript.js- JavaScript functionalityBenefits
Technical Details
Extracted all CSS from inline
<style>tag tostyles.cssMoved all JavaScript from inline
<script>tag toscript.jsUpdated
index.htmlto:Testing
No Breaking Changes
This is a pure refactor that maintains 100% of the existing functionality while improving code organization.