Add a termcap entry for systems without terminfo #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The termcap file is set in config.mk as /usr/share/misc/termcap as it is on FreeBSD and OpenBSD (which use terminfo)... The /usr/share/misc/ is also present on VoidLinux, hopefully it will not break the installation due to inexistant directory.
KAction
suggested changes
Mar 4, 2021
| @@ -6,6 +6,9 @@ MANPREFIX = ${PREFIX}/share/man | |||
| # leave empty to install into your home folder | |||
| TERMINFO := ${DESTDIR}${PREFIX}/share/terminfo | |||
|
|
|||
| # the termcap file is shared among all programs | |||
| TERMCAP = /usr/share/misc/termcap | |||
There was a problem hiding this comment.
This is bad. It breaks staged installs. You need to install it under ${DESTDIR}, and, I think, conditionally.
Something in lines "WANT_TERMPCAP ?= no" in config.mk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The termcap file is set in config.mk as /usr/share/misc/termcap as
it is on FreeBSD and OpenBSD (which use terminfo)...
The /usr/share/misc/ is also present on VoidLinux, hopefully it
will not break the installation due to inexistant directory.
#79